mybooking-es / mybooking Goto Github PK

Font select on customizer shouldn't show standard fonts, we should show Google fonts only.

Topbar is active by default but isn't visible in the page, you need to deactivate and active to make it work.

Widget areas are not ready for internationalization.

see inc/widgets.php

register_sidebar( array( 'name' => __( 'Menú de navegación', 'mybooking' ), 'id' => 'mybooking_primary_menu', 'description' => __( 'Área de widgets a continuación del menú principal', 'mybooking' ), 'before_widget' => '<div>', 'after_widget' => '</div>', ) );

When you add a 3rd level menu on WordPress it does not appears anywhere. It seem to be a Bootstrap restriction and the class WP Bootstrap Navwalker doesn't manage this.

wp-bootstrap/wp-bootstrap-navwalker#115
wp-bootstrap/wp-bootstrap-navwalker#176

Some walkarounds:
https://wordpress.stackexchange.com/questions/240219/nav-walker-bootstrap-display-3rd-level-items-under-2nd-level
https://stackoverflow.com/questions/51398685/bootstrap-4-navwalker-multilevel-menu

The double checking email validation on Complete section of reservation process, doesn't validate and is possible to go next step (Summary) introducing different email addresses without any warning.

Reproduce it:
Follow the reservation process and putting two different adresses when asked.

On Complete template, the class product-detail appears twice adding extra 30px padding that forces content to overflow and adds a right side white bar.

<div id="selected_product" class="product-detail">   
    <div class="product-detail">     
        ...
    </div> 
</div>

Reproduce it:
Navigate to complete section on reservation process and open inspector to see the doubled class. Hover the code line to see the extra padding.

We need a widget area on the nav bar (close to the menu area) so the language flags widgets can be put on it.

Mybooking theme will use the current theme design. It makes the template too complex and not all themes will allow it.

Child themes could change it.

Scroll down icon present on hero's theme has the function of remember user there is more content below the fold. But some times overflows the hero container and appears cutted (or don't appear) due his absolute positioning and fixed values:

.scroll-downs {
    position: absolute;
    top: 80vh;
    right: 0;
    bottom: 0;
    left: 0;
    margin: auto;
    width: 34px;
    height: 55px;
}

Reproduce it:
Give to .hero-header-container a height equal or minor to 80vh.

It's happening since the last update on 2020.03.02.

• Create an empty site
• Create a page with "Mybooking Home" template
• Preview on the browser

I think that giving the theme users a current implementation of the contact page can be useful. Not for us, (we'll design a custom contact page) but theme users that does not want to include elementor o extra design components.

Maybe we can create an options as "Pre-built components"?

If you make a change on parent's CSS and commit it, this is not reflected on child due parent's CSS is duplicated on child and you have to update twice. This is annoying and must be changed on future releases because makes parent-child scheme so ineficient. IMHO.

The overflow-x-hidden fix aplied to avoid the right-side white band that appears on mobile view, makes the sticky summary bar on reservation pages stops to work... I mean don't sticks.

Reproduce it:

1. Apply this fix on Custom CSS section of WordPress:

html, body{
    width:100%;
    overflow-x:hidden;
}

2. Navigate on mobile to the Choose vehicle section; sticky bar doesn't work as desired

When a menu is added to the footer, if the menu shows the title it is too big comparing to the theme design

One of the issues of using Gutenberg editor on Mybooking theme is the lack of support. It affects how blocks are show on frontend and editor and how them match or not the theme.

Actions:

• Add fullwidth support
• Add gutenberg-specific CSS

https://www.billerickson.net/getting-your-theme-ready-for-gutenberg/
https://www.elmastudio.de/en/get-your-wordpress-theme-gutenberg-ready/
https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwenty/assets/css/editor-style-block.css

Sundenly post buttons and image permalinks redirects to the home page on diferent local instances tested. Than doesn't happens with the blog roll posts nor the CPTs.

Reproduce:

• Activate Home News section
• Post anythign on regular blog roll
• Try to read the post

When mobile menu is open language flags are not centered and got to the left

Is so annoying and clients pointed too.

In a fast investigation I found that images load before all DOM is painted... so I tried to put realted CSS on header with no luck. Maybe we need some JS work.

On mobile, the menu displayed is 100% high and the icon to select language is not visible.
If we take away height:100% it doesn't look so nice but it works.

modules > _nav.scss line 191

.navbar-collapse { display: table; width: 100%; height: 100vh; }

Content on theme header widgets makes desappear background image and shows background color and the text lines when you scroll the page and arrives to the sticky breakpoint trigger.

If Mybooking Rent Engine Selector Widget is active anywhere on the page, when it becomes sticky and the content/text on other widget is little, it covers the erros and is not noticeable. Only with long texts is possible to see it.

Reproduce it:

1. Set a widget on home header with a long text
2. Scroll the page

The widget area is too narrow to show the selector form on desktop

It also does not adapt on mobile (margins on both sides)