mwanjajoel / bluesms Goto Github PK

Describe the bug
The current version does not consider error catching and thus it's not clear on when a request fails.

To Reproduce
N/A

Expected behavior
Give clear concise responses based off the API scenarios

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
Error catching makes the SDK more solid

Is your feature request related to a problem? Please describe.
No, it's a great enhancement to ensure the codebase is on point.

Describe the solution you'd like
Adding code formatting using Black.

Describe alternatives you've considered
Using alternative code formatters.

Additional context
N/A

Is your feature request related to a problem? Please describe.
Yes. Tests are missing from the codebase.

Describe the solution you'd like
Adding unit and integration tests to ensure the codebase is rock solid.

Describe alternatives you've considered
Using the SDK without tests which poses a big risk

Additional context
N/A

Is your feature request related to a problem? Please describe.
Yes. Currently the SDK only accommodates one method which is not sustainable.

Describe the solution you'd like
Addition of other SMS methods supported by BlueSMS Uganda.

Describe alternatives you've considered
N/A

Additional context
N/A

Describe the bug
The current base URL in the config file is not being used anywhere.

To Reproduce
Steps to reproduce the behavior:

1. Go to config.py
2. Check the baseURL
3. Search for it anywhere in the project
4. See the issue

Expected behavior
Configurations should be used properly throughout the project

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
Centralising configurations shall make it easier to scale the SDK.