mvf / svn_wfx Goto Github PK

In #2, @vwbij reports that Total Commander's Compare By File Content feature always considers all files as changed when used with SVN repositories. In [1], Christian Ghisler, the author of Total Commander, states:

Sorry, comparison by content isn't currently supported for file system plugins.

So this doesn't seem fixable. It would be interesting to try and understand why though.

[1] http://www.ghisler.ch/board/viewtopic.php?t=47238

In #2, @vwbij reports that the file sizes reported by some SVN servers are bogus, breaking Total Commander's Synchronize Directories function. Local repositories are reported to not have this issue.

Thank you very much for this plugin.
Browsing SVN repositorys with TC is very useful.
I use the Microsoft Visual Studio and the lib https://sourceforge.net/projects/win32svn/files/1.8.17/apache24/
Finally it works.
But when I browser the svn repositorys contains the chinese character, the file name list in total commander is messy code.

I search your code and found that the unicode function is missing.
Can you implement the unicode function kindly.
Thank you !

In #2, @vwbij reports that non-local-ANSI characters in path names are broken due to encoding mismatch. Since SVN uses UTF-8, all paths will have to be converted to and from UTF-16 at the Total Commander API boundary.

Hi,
First, thank you very much for sharing this code. Browsing SVN repositorys with TC is a very usefull thing!

I have problems to find/compile the appropriate dependencies. Does anybody has got some hints? For me, building of SVN, APR and co is very complicated. Does anybody have got precompiled DLL's with libs for a actual version of SVN? At the moment I've got it running with older libs and the dll's of 1.9.4.

It works, but if I select a repo that needs authentication, svn_client_list2 produces a error "No provider registered for 'svn.ssl.server'". But I see, in "initSvn" a simple_promt_provider and a username_prompt_provider is successful (as I can see) registered. Does anybody know why it does not work? Is maybe Cyrus SSL missing in the librarys?

Thank you, all the Best,

Volker Bijewitz

In #2, @vwbij reports that files retrieved from SVN have local modification dates. This breaks Total Commander's Synchronize Directories function unless the Ignore Timestamps checkbox is ticked. Maybe this can be improved by applying the server-side modification dates after download.

In #2, @vwbij reports that FsContentGetValue calls querySnapshot too often, causing lots of (slow) server requests.

Hi,

The selection of the current repository entry in querySnapshot was broken. It finds a match for "KEY" in "KEY_AB", "KEY_DE" and so on. Here the fixed loop head:

while (loc)
{
    const int minLen = min(loc->title.len, pathLen);
	if (!strncmp(path, loc->title.data, minLen))
    {
        apr_pool_t *subPool = NULL;
        svn_error_t *err;
        svn_opt_revision_t revision;
        size_t subPathLen = 0;
        char *buf = NULL;
        strbuf_t s;

		// Lets look if this is correct. If the path is longer than the title, we need to see
		// a path seperator next (\ or /). If not, we have it to do with a matching part of a name
		// ("UDO_NEW" instead of "UDO"). Good match would be: "UDO/DevGuide" or "UDO\DevGuide".
		if(pathLen>minLen)
		{
			if(!((path[minLen]=='/')||(path[minLen]=='\\')))
			{
		        loc = loc->next;
				continue;
			}
		}

        /* found it, fetch data from SVN */
        subPool = svn_pool_create(Subversion.pool);
        subPathLen = strlen(path + minLen);
        buf = (char*)apr_palloc(subPool, loc->url.len + subPathLen + 1);
		s.data = buf;
		s.size = loc->url.len + subPathLen + 1;

All the Best,

Volker