mutinywallet / mutiny-node Goto Github PK

Would be cool to sign in to stacker news!

This could be configured on the user's side without them having to run the mutiny web server themselves

when a transaction comes in and the page jumps to the tx view, the link goes to testnet mempool when there's not really a regtest url to visit. maybe disable link when on regtest, and make sure mainnet mempool is the default when that's the network selected.

so we can clear out peers that are disconnected for instance

• send confirm page
• send pending page
• activity log / toasts on home page
• parse invoice
• deposit action screen: show QR code
• error screen
• error toasts

Would also be beneficial to add being a RGS provider to the websocket proxy

• send screen
• send amount specifier
• send confirm
• send success
• receive screen
• receive success
• home screen

this will help with MutinyWallet/mutiny-web-poc#30

Needs identity / auth, maybe derivable from the 12 words?

• list channels
• list utxos
• list onchain txs
• list lightning txs
• list peers
• backup info

• setup
• open channel

Not always needed

When connect peer happens and channel is initiated, we save the peer address. We continue to connect to this peer automatically. If the peer address changes, this will keep failing to connect. We can connect to the new peer address, but this does not update the entry we have so it will continue to fail.

We should replace the address if we do a successful connect_peer if we already have a different peer address stored in the DB.

maybe toolchain caching could help? actions-rs/toolchain#54

Great idea on this wallet. It's awesome! I've detected a UX problem on the settings screen. When I tapped the arrow at the bottom and clicked the settings icon, I had no idea that it was about to display my seed phrase in plain open sight. I would suggest adding an extra step and warning the user that sensitive info is about to be displayed. A simple "tap to reveal" button could fix the issue.

Further reading

Example of warning the user first

Based on this comment:

#36 (comment)

Will need to implement JsValue for MutinyError:

impl Into<JsValue> for MutinyError {
    fn into(self) -> JsValue {
        todo!()
    }
}

probably want to use something like this:
https://github.com/undecaf/barcode-detector-polyfill

the other way would be to create our own wrapper around something like this:
https://github.com/piderman314/bardecoder

this drills on through create_phantom_invoice

Currently when trying to make a payment I will get the error Cannot route when there are no outbound routes away from us. Still debugging if this is from a channel error or if we're doing something wrong with the payment.

more context:

Currently we hardcode fees, we previously talked about having a thread that fetches fees every few minutes and saves them for the main thread to read from.

I've googled this error and found some things for webpack and other frameworks but nothing I found references a file we actually use so I don't know where to config this for whatever it is we use in place of webpack.

Run npm install
npm WARN deprecated [email protected]: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated [email protected]: This SVGO version is no longer supported. Upgrade to v2.x.x.

added 1448 packages, and audited 1450 packages in 16s

226 packages are looking for funding
  run `npm fund` for details

7 high severity vulnerabilities

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> [email protected] build
> react-scripts build

Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

/static/media/node_manager_bg.fb2229fd9cd5d2e00d3c.wasm is 5.66 MB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.

need to find a way to ignore these, also a way to add a real description

• create invoice
• pay invoice
• decode invoice
• open channel
• close channel
• connect peer
• list peers
• get new address
• pay to address
• check address
• get balance
• list txs
• list utxos
• list lightning
• list channels
• create wallet
• set password
• get seed
• invoice status
• bitcoin price
• tx details

these have gotten really hairy, need to refactor or at least hide some logic in utility functions

potentially related to MutinyWallet/mutiny-web-poc#31