musescore / mdl Goto Github PK

Currently samples are .ogg vorbis format:

• Vorbis Audio
• Stereo
• 44100 Hz
• 192k/s
  https://github.com/musescore/mdl/blob/master/resources/sound/MDL_samples/auxiliary/agogo_high_F.ogg

Ogg Vorbis is a lossy format which is not ideal for high-quality sounding performances/recordings.

Within the SFZ and Soundfont world it is a standard to share instruments in a lossless format such as:

• .wav
• .flac
  https://github.com/sfzinstruments

You can create a "compact" lossy version by converting .flac back to .ogg afterwards using the commands.

1. Convert .flac to .ogg using ffmpeg
   for file in $(find . -type f -name '*.flac'); do ffmpeg -i "$file" -b:a 192k "${file%.*}.ogg"; done

2. replace all references of flac to ogg in sfz files
   find . -type f \( -iname \*.sfz -o -iname \*.txt \) -exec sed -i -e 's/flac/ogg/g' {} \;

3. Delete the old .flac files
   find . -type f -name '*.flac' -type f -delete

This can be run in GitHub CI such as:
https://github.com/studiorack/studiorack-workflows/blob/main/.github/workflows/sfz.yml#L97

Of course none of this is possible without the lossless versions being the originals

The MDL prefix in front of every score template is redundant and useless. Should the templates be renamed?

Hello
Thank-you for open-sourcing your instrument!

Currently you have a custom license.txt file:
https://github.com/musescore/mdl/blob/master/license.txt

GitHub cannot parse custom licenses in the UI

Or provide them via the search API:

"license": {
    "key": "other",
    "name": "Other",
},

https://api.github.com/repos/musescore/mdl

Using a license template will fix this and make your repo searchable by license:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository

Thanks!