murrayju / durak

a card game

Hi there 👋

Check out: murrayju.com

durak's Issues

Attacker should not have to click "it's beat" when their hand is empty

Make play field (attack and defence area)

we should use this:
https://github.com/atlassian/react-beautiful-dnd

Persist games to the db

Games are currently only stored in sever memory. They should be persisted to the db, and survive a server restart (deployment).

Animate card movement

Game will feel more interactive, and it'll be more clear what's happening in some cases.

Don't allow starting game with 1 player

It's not playable.

Only primary attacker can play the first attack

Currently secondary attackers are allowed to throw the initial attack.

Allow player to reorder cards in hand

Probably best done with drag and drop.

Can't see beat button on Safari

two players out in a row, skips a turn

player can see all cards sometimes

to reproduce
make a "table" with non-incog
create person
then open with incog the table link
start with non-incog
otherwise it seems like it works fine

Defending player should not have to click "it's beat" button

Just having all of the attackers do it should be enough to proceed.

add an undo

maybe people should have to vote to agree

Give attackers a chance to throw more attacks when defender picks up

Currently if the defending player doesn't ask before clicking the button, there's no chance for attackers to fill the empty attack slots when they are picking up.

Drag and drop card play

Should be possible to drag and drop cards to play them.

people keep clicking the pick up button accidentally

Maybe make it orange or something less inviting? Move it somewhere else?

Something something ids and keys

Warning: Encountered two children with the same key, 'X:X' - so this is flooding the console as I'm sure you are aware - the ids for the cards are not unique which makes this interesting

I'm just wondering what you thought process was here - I feel like if you build a deck, all the cards should be assigned a unique key and another attribute should control their state (flipped or not) - It seems like we are controlling both of these things with the id field. I think it is important to not show the card identity in the page's inspectable elements, so your approach makes sense, but there should be some kind of uuid, right?

Rename 'game' -> 'table'

Several things would be clarified if what is currently named 'game' were renamed to 'table'. A table is what gets a unique URL, and is what the players join. A given table can have multiple games (in series, not in parallel).

Scale layout for smaller screens

make the hands look pretty for smaller resolutions

auto timer when user goes out

don't make everyone click it's beat when there's nothing to do.

it's beat should not be reset by someone making an invalid attack

In general, if someone attempts something invalid, it shouldn't reset the state of votes by other users.

Observer cannot see players' hands

The cards are fanned out backwards, such that only the value of the top card can be read. They need to be fanned out in the opposite direction.

Players on sides should not drift into the play area as they get more cards

The player position should be stable.

Show list of spectators

Players should be able to see if there are spectators

Add API for playing attack/defense cards

This is how players will play cards.

Move pick-up button to play area

It's too easy to accidentally click the pick up cards button where it is. It'll make more sense under the attacks in the play area.

Cleanup old games

Nothing ever removes games from the db, so they will accumulate. Some sort of cron job should delete old games that nobody is connected to.

Show connection indicator for each player

Would be nice to know if a player got disconnected.

Show trump indicator after trump card is drawn

Once the trump card is drawn, there's no visible indicator of what the trump is.

Add a test framework

Probably use Jest.

Should not be able to attack player who ran out of cards

Currently the attack limit is 6, so it lets people attack when the defender is out of cards.

Add a full screen toggle button

Don't require beat votes when no more valid plays can be made

If in a state where no more plays can be made:

• 6 defended attacks
• defender is out of cards

It should not be necessary for all players to click the "it's beat" button. Could wait for a single vote, or use a countdown timer (or both).

keep player positions consistent on screen

People find it confusing when a player goes out, and the remaining players move around on the screen.
May be best to keep all of the players there in the same spot, and just indicate them as being out.

Support dealing in new players

If someone joins late, it should be possible to just deal them in mid-game.

Lowest trump goes first

Current starting player is random, should be the player with the lowest trump.
This should somehow be revealed to the other players as well.

Turn skipped when primary attacker goes out

If the primary attacker plays all of their cards to go out, the play then effectively advances two turns, skipping a player.

It's beat token

Should be able to see when other players say it's beat

Clients should be able to choose to be a spectator

Currently, clients who join after the game has started are added as spectators, and will be players in the next round.
We should return to the lobby between games, and allow users to choose spectator/player.

Unique ids for obscured cards

This is mostly to enable animating the movement of obscured cards. Each card should have a unique (per deck) id that is unrelated to the card's value, and is available whether obscured or not.

Support players leaving the game

Players should be able to leave the game, and other players should be able to kick inactive players from the lobby.
This could be done somewhat automatically, with a timer around when the eventstream was last connected.

Move the it's beat button

It should be up in the play area, just like the pick up cards button.

Durak should be attacked first on all but first game

shorter timer when at 6 cards

Show an action log

Might be helpful to show a running log of the actions that were taken. Maybe not a complete list of everything, but the last N actions.

The discard pile should be more disheveled

The discard pile is too neat, and looks like a draw deck. Cards should be piled up a bit more randomly.

Mobile layout gets cut off at bottom

Doesn't happen in the chrome dev tools simulator thingy, but does happen on a real phone. Seems to be caused by how the address bar is there and is supposed to disappear on scroll.