mui / mui-public Goto Github PK

Summary

Our mocha tests run serially which is inefficient and slow. For example in https://github.com/mui/mui-x, https://app.circleci.com/pipelines/github/mui/mui-x/60861/workflows/e2ea2b79-d335-4e79-874b-656570f42f38/jobs/347360/steps tests are way too slow >14 minutes, and only 1/2 of the CPUs available.

We should run these tests in parallel. Mocha doesn't support it mochajs/mocha#4958.

Examples

• Vitest: https://vitest.dev/config/#pool

There are 2 ways to reproduce this:

Steps to reproduce 1

Steps:

1. Open an issue, have workflows/issue-cleanup.yml run once
2. Transfer the issue to a different repository, workflows/issue-cleanup.yml runs again

For example mui/material-ui#41139

Steps to reproduce 2

Steps:

1. Open a blank issue with already the mention

For example #149

Search keywords: issue-cleanup.yml runs twice

Summary

MUI X has a workflow that allows to leave closing issue comments like: mui/mui-x#12944 (comment).

It would make sense to me to do the same to all MUI's repositories.

Examples

No response

Motivation

No response

Search keywords: -

UI for mui/material-ui#23638

Current state: https://mui-dashboard.netlify.app/test-profile/199723

These are not ordered by their implementation timeline but as a convenience for referencing individual work-items.

1. MVP (https://github.com/eps1lon/mui-contributor-dashboard/pull/21)
2. link to CircleCI run
   With https://github.com/eps1lon/mui-contributor-dashboard/issues/28 we link to the GH PR from which the job is available. Might be sufficient. But https://github.com/eps1lon/mui-contributor-dashboard/pull/28 already provided the data so that part is at least done.
3. link to test (https://github.com/eps1lon/mui-contributor-dashboard/pull/25)
   Implemented by tracing.
4. deduplicate phase
5. more analysis (e.g. percentiles)

Summary

Based on the discussion mui/mui-toolpad#3396 (comment), we have an opportunity to improve the reliability of dependency installs for contributors across all projects.

• preinstall script "npx only-allow pnpm"
• packageManager field
• engines.pnpm field

repositories

• toolpad
• X
• base
• pigment mui/pigment-css#126
• core
• mui-private #169
• mui-public
• ?

Summary

We have these feedback channels today:

• docs-feedback
• docs-feedback-x
• docs-feedback-toolpad

Soon or later, we will want:

• docs-feedback-base-ui
• docs-feedback-material-ui
• docs-feedback-pigment-css
• docs-feedback-xgrid
• docs-feedback-xcharts
• docs-feedback-explore
• docs-feedback-toolpad
• docs-feedback-design-kits

Motivation

So each team can focus on its own product, without the notification noise of others.

Summary

https://circleci.com/docs/github-apps-integration/ CircleCI’s GitHub App integration provides fine-grained permissions. It's strange for a member on the Base UI team to be able to change profoundly the config of MUI X. As we grow, moving in this direction would make more sense. Well, unless we decide to to consolidate on another CI, but I don't see clear problems with CircleCI today, it seems good enough: https://www.notion.so/mui-org/code-infra-Migrate-out-of-CircleCI-42350363b7344380a9961cf9731aae31.

See the guide for the migration https://circleci.com/docs/github-apps-integration/#Moving-from-github-oauth-app-to-github-app.

However, the list of not yet supported features feels like a deal-breaker: https://circleci.com/docs/github-apps-integration/#currently-not-supported

• Cancel redundant builds
• Scheduled pipelines
• Stop building
• Passing secrets to forked pull requests
• Manual trigger pipeline option

Examples

No response

Motivation

No response

Search keywords: -

Context 🔦

It works in v0.1.19.

It crashes in v0.1.20 with:

Noticed this in https://www.notion.so/GitHub-community-issues-PRs-Tier-1-12a84fdf50e44595afc55343dac00fca?d=18038d4bbdbb40bc8a1ca714803aef13&pvs=4#c59aa53a2054400b98613dfb84b4cb03

Maybe mui/mui-toolpad#1991 is the origin.

Your environment 🌎

  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Summary

GitHub labels, 🏷️ GitHub labels being the source of truth.

• We saw with mui/mui-x#10810 that it can be time-consuming.
• Possible action to use. Can sync from a config file. Can also sync global labels (across the repos) and repo-specific labels (useful when they are targeting specific components or features) https://github.com/marketplace/actions/label-sync

Search keywords: -

cc @michelengelen

Summary

This issue is similar to GitHub workflows https://github.com/mui/mui-private/issues/360 shared in the organization, but for issue templates. This should be doable with https://github.com/orgs/community/discussions/22451#discussioncomment-3236785.

Example

Always the same between repositories:

• RFC: https://github.com/mui/material-ui/blob/master/.github/ISSUE_TEMPLATE/3.rfc.yml but with a different prefix than 3. It would rank too high in the order. 7 sounds better.

There are other issue templates but none that seem that we can share.

Motivation

Discussed in mui/mui-x#11995 (comment).

Search keywords: Issue template

Search keywords:

Summary

We ran all the tests in the mono repositories with Mocha, even if the source didn't change. It would be great to skip all the tests in which sources were untouched.

Examples

No response

Motivation

Solving #170 should much likely be done first since skipping test can be unreliable,

Navigate to tools-public and run yarn. I got the following error:

[5/5] Building fresh packages...
[-/4] ⠐ waiting...
[2/4] ⠈ esbuild
[3/4] ⠈ cpu-features
warning Error running install script for optional dependency: "D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features: Command failed.
Exit code: 1
Command: node buildcheck.js > buildcheck.gypi && node-gyp rebuild
Arguments:
Directory: D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features
Output:
D:\\workspace\\mui-public\\tools-public\\node_modules\\buildcheck\\lib\\index.js:133
        throw new Error('Unable to detect compiler type');
        ^

Error: Unable to detect compiler type
    at new BuildEnvironment (D:\\workspace\\mui-public\\tools-public\\node_modules\\buildcheck\\lib\\index.js:133:15)
    at Object.<anonymous> (D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features\\buildcheck.js:5:12)
    at Module._compile (node:internal/modules/cjs/loader:1191:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1245:10)
    at Module.load (node:internal/modules/cjs/loader:1069:32)
    at Function.Module._load (node:internal/modules/cjs/loader:904:12)
warning Your current version of Yarn is out of date. The latest version is "1.22.19", while you're on "1.22.5".
info To upgrade, download the latest installer at "https://yarnpkg.com/latest.msi".
Done in 360.69s.

OS used: Windows
yarn version: 1.22.5

I could still do yarn dev and run it locally, haven't noticed some issues.