Mui input base text area style is not applied correctly with input props on 5.15.11 from 5.15.10 about material-ui

[ZeeshanTamboli]

I think I know why this broke. But before explaining, @TangMichael, why are you applying the height style when the rows prop already determines the textarea height using the rows value?

[DiegoAndai]

@ZeeshanTamboli this broke in #40789 and, for some reason #41369 didn't fix it. May I ask you to take a look? Weirdly, the height seems to be multiplied x4 🤔

[TangMichael]

@ZeeshanTamboli We used the height style to have a more precise size to match the designs to the pixels. Can the rows value be used to do the same?

After seeing your comments with the rows, I can see that the height of the style is multiplied by the rows number which is why on v5.15.11+, the height is 400 when I have rows set to 4 and the style of the height set to 100.

[ZeeshanTamboli]

If you want the height to match the design exactly, why are you using the rows prop?

[TangMichael]

The codebase already contained those two props and it worked fine so it was kept like this. We only noticed this issue when upgrading the library version.

I can remove one of the other if that fixes the issue. Would you say this is intended behaviour starting from 5.15.11+?

[ZeeshanTamboli]

Would you say this is intended behaviour starting from 5.15.11+?

This is the correct behavior. It was incorrect before 5.15.11, and the new logic in #40789 exposed this improper prop usage. Either provide a static height using the height style or let the textarea determine its height using the rows attribute. The combination of both doesn't make sense. I think we can close this issue.