Comments (6)
@natsid Thanks for reporting the issue with a clear description 👍. You are correct. @DiegoAndai We should consider this in the component refactor. It might be a breaking change if we implement it now or maybe not, but we should treat it as a bug since we claim to provide full accessibility support. @natsid Feel free to create a pull request if you'd like.
from material-ui.
@natsid I created PR #42914 to fix this. In my opinion, it's not a breaking change, so it can be included in v5, but it depends on the reviewers. If not, v6 will be stable soon, targeting July 28th as per the latest release note.
from material-ui.
Thank you for the quick reply, @ZeeshanTamboli ! I haven't looked into how involved the PR would be. At first glance it seems simple - just add a wrapper div with role="heading" and aria-level="?". However, I think we'd also need or at least want to add a new (optional) input on AccordionSummary for the aria-level value. I do think you're right that this could be a breaking change since users' CSS selectors may depend on the current structure. In addition, whatever default value we choose for aria-level could also be considered "breaking" since it may conflict with existing heading structures where it is used.
Do you know if we'd be able to patch this into v5 or if it would only make sense to add into v6?
from material-ui.
@natsid Thanks for your insights on why it could be a breaking change. It makes sense to add it in v6 or v7, not into v5.
from material-ui.
Ah, OK @ZeeshanTamboli . Just trying to get a temperature check on how firm that is. I'm personally invested in seeing the fix in v5 since that is what my project is in and v6 is still alpha - and we wouldn't be able to update to v6 until it is stable. Is there any way I can make the case for a v5 bug fix?
from material-ui.
Thank you so much @ZeeshanTamboli !
from material-ui.
Related Issues (20)
- [material-ui][Menu,Popover] `slotProps` cannot modify backdrop slot HOT 1
- [material-ui][v6] variants breaking changes lead to unexpected behavior in component customization HOT 3
- [material-ui][Autocomplete] How to use autocomplete (multiple) with an API? HOT 5
- [codemod] `v6.0.0/styled`, `v6.0.0/sx-prop`, `v6.0.0/theme-v6` codemods fail parsing tokens HOT 2
- [codemod] `v6.0.0/sx-prop` produces strange changes HOT 2
- [material-ui][Popover] How to create a hover card using a popover? HOT 3
- aria-hidden warning HOT 2
- I hope to use storybook MUI to create the new UI library, but the themes from material ui and joy ui can not work together, help me please. HOT 1
- Box modules is broken HOT 1
- Temporary drawer changes content and header width when open in an iframe
- Joy UI: Disabled Link IconButton appearance appears to still be enabled HOT 5
- [joy-ui][Select] Option flickers for multiple and controlled Select
- Material UI 6 CssVarsProvider causes Suspense to reload async components HOT 3
- Can't integrate latest next.js with pages router with MUI
- Microsoft Ribbon Style HOT 2
- [RFC] Change Checkbox padding from 9px to 8px
- [material-ui][Divider] Add aria-orientation
- Accordion's bottom outline disappears when expanded (only in safari)
- [Typography] text color not working in v6 + Pigment CSS HOT 10
- V6 next/link import produces error with pigmentcss HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.