Comments (5)
I can share a working POC later (I have a minimal demo working). But nested themes will work like this -
- You provide a single theme object through the bundler config. This is used as a reference to generate and inject css variables.
- If you want to override parts of the app, you can use a custom
ThemeProvider
(which is not based on context
Suppose you have this as the main theme -
{
palette: {
background: "0 0% 100%",
foreground: "240 10% 3.9%",
primary: "240 5.9% 10%",
border: "240 5.9% 90%",
},
}
And this is how you'll override the global values to scoped areas on the page
<ThemeProvider theme={{
palette: {
border: "240 59.7% 56.9%",
},
}}>
<div>Your demo</div>
</ThemeProvider>
It'll generate inline styles of css variables that have overriden values that are provided, like this -
Any component inside this ThemeProvider
will use css variables with local values for styling.
So ThemeProvider
is not actually a context in this case, it's just a div that does not have it's own layout.
Note that this only handles theme token but not other overrides, like component defaultProps. For those, we can still have ThemeProvider
with context similar to what we have right now.
from material-ui.
Off-topic (style theme nesting isn't something I was thinking of covering in this issue)
As far as I understand, nested theming for styles should be supported by using CSS variables. It's the <CssVarProvider>
component's responsibility to get this to work (which IMHO would be better called ThemeProvider). The zero-runtime should only hard code theme values that aren't CSS variables, or use CSS variables when they are.
It'll generate inline styles of css variables that have overriden values that are provided, like this
We should try to have no inline style in the framework for strict CSP policies. If we can have this in a class name, this would be better.
from material-ui.
We introduce a server side theme, to live in the server bundle, alongside the a client bundle theme
I don't see a picture of it. Is server-side theme is the one you define in the config (e.g. next.config.js)?
We should try to have no inline style in the framework for strict CSP policies. If we can have this in a class name, this would be better.
Then, how do you support dynamic runtime styles? Inline style seems to be the only way to connect JS with CSS statically.
// css
.hash {
opacity: var(--hashed-var);
}
// js
<div style={{ '--hashed-var': opacity }}>
from material-ui.
how do you support dynamic runtime styles?
@siriwatknp Property assignment: #19938
Is server-side theme is the one you define in the config
For Emotion RSC and runtime theme dependencies, you define it once in a RSC and once in a React Client Component. Actually because of this: https://nextjs.org/docs/app/building-your-application/rendering/composition-patterns#supported-pattern-passing-server-components-to-client-components-as-props we can likely have a single component that does both client and server context assignment under the hood.
For zero-runtime RSC, yeah, you also need to define it in the plugin that does the transpilation.
from material-ui.
They use the React.cache for the server context: https://yak.js.org/how-does-it-work
from material-ui.
Related Issues (20)
- [docs-infra] Create a feature list/highlights component
- [joy-ui][IconButton] Wrapping IconButton over an Avatar HOT 2
- [pigment-css] Support module aliases in nextjs-plugin HOT 2
- [material-ui][Autocomplete] React keys being passed directly to JSX without using spread HOT 3
- [material-ui][Text Field] Multiline variant cannot be made to scroll horizontally HOT 1
- [joy-ui][Circular/Linear Progress] soft (default) variant is hard to see in dark mode HOT 1
- [codemod] Error while running command ````pnpm tc badge-props```` and ````pnpm eslint```` HOT 3
- [material-ui] styleOverrides behaviour is different in MUI v4 and v5 HOT 4
- [material-ui][Select] Issue with components in fullscreen view mode HOT 2
- mistake
- [material-ui][Select] Basic demo label text is overlapping HOT 2
- Permission denied when opening Dialog while Proton Pass is active HOT 4
- [docs-infra] Add line and word highlighting on code blocks
- [joy-ui] Allow extending the color inversion feature HOT 2
- [material-ui] Is there any way to apply the Tailwind's `dark:` class prefix? HOT 2
- [docs] Accordion TransitionProps vs slotProps.transition
- [docs] Demo BasicModal crashes HOT 8
- [material-ui][Select] "&ZeroWidthSpace" is being rendered as child element HOT 2
- [typography] Allow sx prop-like responsive values on the variant prop HOT 3
- [docs] User Persona Proposal for Material UI HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.