mudmin / usplugins

UserSpice 4.4+ plugins

usplugins

UserSpice 4.4+ plugins

usplugins's Issues

Nested Forms and dubble class call on uedit.php

Firefox had issues with the update button so i found nested forms, moved the primary form call to just befor the second <div class=row> and also found that the update button was
<div class="btn-group"><input class='btn btn-primary' type='submit' value='Update' class='submit'/></div>
changed to
<div class="btn-group"><input class='btn btn-primary submit' type='submit' value='Update'/></div>

This seemed to fix the problem.

IP is blocked after the first fail attempt

$settings = $db->query("SELECT * FROM settings")->first();

should be $settings = $db->query("SELECT * FROM plg_api_settings")->first();

in usplugins/src/apibuilder/assets/apitools.php (line 110)

Plugins Admin Settings part of header.

I noticed that in US5 that the plugins admin config pages show the configure plugin data within the header of the page.

The Plugin Manager Page looks good..

However the plugin settings is part of the header...

Deprecation Warning for mathFunction bindec in the benchmark plugin

I get a deprecation warning for the performance benchmark plugin using the PHP version 7.4.6:

Deprecated: Invalid characters passed for attempted conversion, these have been ignored in ./usersc/plugins/benchmark/configure.php on line 127

It is happening when the mathFunction bindec is being called.
This behaviour is documented here:

binary_string:
The binary string to convert. Any invalid characters in binary_string are silently ignored. As of PHP 7.4.0 supplying any invalid characters is deprecated.

Profile picture from facebook

It would be nice if facebook_login plugin could also update user profile image with facebook one. It's super easy, I already tested that by modifiing code on my website, all that has to be done in fb-callback.php file is (bold represents changes to be done):

• add line: $pic = "http://graph.facebook.com/".$fbuser['id']."/picture?type=large"; (in my case it's on line 118 right above user existance check)
• edit fields line when user exists: $fields=array('fb_uid'=>$fbuser['id'], 'logins'=>$newLoginCount, 'last_login'=>$newLastLogin , 'picture'=>$pic); (in my edited version line 125, originally propably little bit higher)
• edit fields line when user doesn't exist: $fields=array('email'=>$fbEmail,'username'=>$username,'fname'=>$fb_fname,'lname'=>$fb_lname,'permissions'=>1,'logins'=>1,'join_date'=>$date,'last_login'=>$date,'email_verified'=>1,'password'=>NULL,'fb_uid'=>$fbuser['id'] ,'picture'=>$pic); (in my case line 176, originally propably little bit higher)

And that is that. This simple edit gets URL of facebook profile image, which can than be used instead of Gravatar URL. This basically makes registration easier for users, because they don't need to upload their profile picture anywhere, it also automatically updates with facebook profile picture update.

I already sucessfully implemented and tested these changes on my website, I just thought someone else could appreciate it and they won't need to reinvent the wheel. If you don't think it's good idea to implement it or you find better solution, feel free to ignore this.

LDAP Login Plugin: Login fails when password contains ampersand (&)

If the password contains '&' you get the following error:

Warning: ldap_bind(): Unable to bind to server: Invalid credentials in usersc/plugins/ldap_login/hooks/loginFail_body.php on line 49

This appears to be a known issue with the ldap_bind function. I could only make it work using html_entity_decode on the password as suggested here: https://stackoverflow.com/questions/12858493/php-ldap-bind-fails-when-password-contains-ampersand

Can't add users in the SaaS plugin

When trying to add users to a org as a manager they never get added to the DB when you select manual add.

Facebook Login - Undefined variable

Hi,

in your facebook login, there is a variable not defined, this should have the user_id, for updating us_ip_list.

"PHP message: PHP Notice: Undefined variable: feusr in /var/www/weisat_eu/usersc/plugins/facebook_login/assets/fb-callback.php on line 140