msqrt / shader-printf Goto Github PK
View Code? Open in Web Editor NEWSimple printf functionality for GLSL.
License: MIT License
shader-printf's People
Contributors
Stargazers
Watchers
shader-printf's Issues
glGetProgramResourceiv bufSize should not be in bytes.
On line 52:
glGetProgramResourceiv(program, GL_SHADER_STORAGE_BLOCK, glGetProgramResourceIndex(program, GL_SHADER_STORAGE_BLOCK, "printfBuffer"), 1, &prop, sizeof(binding), nullptr, &binding);
sizeof(binding) is wrong, it should just be 1.
See https://www.khronos.org/opengl/wiki/Example_Code#Program_introspection for proper example usage. See KhronosGroup/OpenGL-API#52 about this confusing naming.
`max()` function not declared
shader-printf/shader-printf/shaderprintf.h
Line 201 in e74046e
On my Linux machine I get this error:
shader-printf/shader-printf/shaderprintf.h:219:48: error: ‘max’ was not declared in this scope
219 | if (extension != std::string::npos) version = max(extension, version);
A simple fix would be to use std::max() instead.
unwanted line offset
shader-printf/shader-printf/shaderprintf.h
Line 212 in e74046e
I think here the
bufferInsertOffset should be after the '\n'. Then compiler errors work in my environment.-Wshadow gcc warning
shader-printf/shader-printf/shaderprintf.h
Line 225 in e74046e
this variable shadows this declaration:
shader-printf/shader-printf/shaderprintf.h
Line 185 in e74046e
And thus issues a warning when the gcc compiler option -Wshadow is enabled:
shader-printf/shader-printf/shaderprintf.h:246:8: warning: declaration of ‘inString’ shadows a previous local [-Wshadow]
A simple fix would be to insert curly braces {} around line 183 to 196.
License?
This project is awesome, but I'm unsure if I'm allowed to use its code or not in my own projects because there's no apparent license on it.
If you'd like others to use this library, could you clarify its license? A LICENSE or COPYING file in the repository and/or a copyright + license inline in the shaderprintf.h header would do :-)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.