msoeken / kitty Goto Github PK

I got this warning when calling cmake:

CMake Warning at test/googletest/googletest/CMakeLists.txt:47 (project):
VERSION keyword not followed by a value or was followed by a value that expanded to nothing.

It can still configure and compile successfully, so it's not a big problem I guess.

The code quality check is shown as failing. I tried to login to Codacy with my GitHub account but it still says "Something went wrong, we couldn't reach that repository. Could not find repository manual/msoeken/kitty". @msoeken, do you plan to do something with that (fix it or remove it)?

static_truth_table and dynamic_truth_table do not implement operator== and operator!=, so code like tt1 == tt2 does not work. It seems you still can compare truth tables with something like the following (untested) code:

bool eq = true;
for (auto it = tt1.begin(), it2 = tt2.begin(); ; ++it, ++it2) {
  if (it == tt1.end()) {
    eq &= it2 == tt2.end();
    break;
  } else if (it2 == tt2.end()) {
    eq = false;
    break;
  }
  eq &= *it == *it2;
}

Is it possible to implement operator== and operator!= on these classes to avoid having to do this? It should be possible to do some template-based specialization to optimize these too.

OTOH perhaps I've misunderstood something and equality comparison makes no sense on these classes. In which case, I would be interested to learn of this too.