mslegrand / pointr Goto Github PK

shinyFiles requires a button, but pointR uses menu. One approach would be to modify the shinyFiles and integrate the resulting javascript/R directly into pointR.

Currently .R files are internally using .ptR mode. This results in parsing as .ptR, which produces undesirable effects:

for example when creating a custom control, we might have
tagList( singleton(tags$head(tags$script(src = "widgetCntrl.js"))), div( id=inputId, newWidgetCntrl(WH=wh, inputId=inputId, theta_0), "data-theta"=theta_0, class="widgetCntrl" ) )

But a warning is issued that src is not an attribute of tags$script.

To fix either

• use the usual R parser as in shinyAce or

• fix the ptR-ace parser to ignore this.

Additionally, the dnippets bar appears, with options not appropriate to an plain R file

The issue is to be able to select a tagged set, and then drag the points (one at a time) in that set. Currently, points picks the highest index at a given location, value does too. This is because we allow tag selection using point and click. Only the drag screen disables the point and click tag selection. So the best approach is to modify the drag screen to drag either a group or a single point.

ace editor: warning onClick is not an attribute of Path. How should this be handled?

when the mouse click is used to select a point, it selects the next point rather than the point that was just clicked. This is counterintuitive, especially when trying to insert an intermediate point in a polyline.

Tabs to wrong location

for tribble we label our columns using ~foo, but the parser flags this as invalid syntax.

Most needed attributes should come first.
One approach

1. custom attributes first (i.e. cxy, rxy, xyz, ...)
2. regular attributes second
3. presentation attributes third
4. content elements forth

There appears to be an issue with incorporating shinyFiles into pointR. The problem seems to originate within the svg plots. I can only speculate at this time, but this is probably a symptom of a serious issue, yet to be discovered.

R files with no commit button cannot be saved

This issue arises because a file is flagged as modified only after a change has been committed.
Consequently, any changed to an app.R, or any *.js cannot be detected because of a lack of commit button.
To solve this we can either introduce more buttons (yuk) or notify the server when ever a notSaved status changes. A notSaved status would be sent whenever the value of undoStack.length>0 changes.

This is a design issue. Will need to rework how code is updated after point/transformation edition.

We should have the window resize accordingly.
What this would entail is:

1. ace editor and graphics resize accordingly
2. splitter maintains its proprotional position
3. No wrapping!!!

The current implementation uses file.choose, which looks good for opening, but not for saving. In particular, the button is open, not save. There must be a better widget to do this.

snippets has been disabled. Need to reinsert snippet capabilites

load R file and submit should not reject (and undo) just because of a missing svgR or ptR.
If svgR is return, should graph it.
If no ptR, then do not provide editor selection of points, but still should graph (assume no error)
If plain R, just output the console out.

currently all new pages go through ptRACE

• We need to reroute for javascript support
• Some code, such as select null has been disabled. should be reenabled
• dragndrop for javascript,
• bookmarks are not working

slider input not very readable

• numbers at bottom are clipped

• background should be white to improve visability

Proposed changes to tagging frequency

1. Tag frequency is set (fixed) during the first tagging operation.
   In particular, when first tagged, a popup modal will ask for frequency and
   confirmation.
2. If the tag frequency is set to a period p>0, (aka. periodic tagging) then all subsequent
   indices that are 1 mod p are to be tagged.
3. Periodic tagging makes no exceptions, thus deleting a point or inserting a point does not change the indices, (unless at the end).
   Rather the points associated with the tags, change instead.
   In particular, if a tagged point is deleted, the next point becomes tagged, and the tagging data frame remains intact except for possibly
   the last row. If the tag index of the last row exceeds the number of points, that row is deleted. A similar situation occurs for insertion
   of a point.

Note Requirement 3, appears simpler, but actually creates a new case. Formerly, both manual and periodic
inserts and deletes were handled identically (except for the addition of a tag when necessary). Now they are not.

Implementation changes required for the above

• 1. modulePointsBar tagFreq selectInput, becomes an output (readonly)
• 2. serverMouseClicks::observe input$mouseMssg : cmd= add, delete are to be rewritten
• 3. serverPlotBarPoints::observe pointInfoList$tagFreq() needs to be rewritten
• 3A. popup modal to ask for frequency and confirmation
• 3B. tag button is hidden (or disabled) for freq>0.

When save file source changes no notification of update occurs

backtic is not recognized by parser

Warning in stri_match_first_regex(string, pattern, opts_regex = opts(pattern)) :
argument is not an atomic vector; coercing

No clue where in the code this is coming from.

Translate doesn't seem to do anything
Rotate causes crash

Currently user must view/edit snippets with another application (text editor). To make snippets more usable, we need to intergate a snippet editlr

pointR is already using the script element, so if a user creates a script element, we need to intercept that and merge it's content with the pointR script element. Also when doing this, one needs to handle any potential conflict in variables and or functions.