mrod5 / pyturb Goto Github PK

Reactants with other oxidizers than air cannot compute the Fuel Air Ratio (FAR), as it is not yet implemented. As Issue #17 implements oxidizer mixtures, FAR should be easily calculated.

If a GasMixture is created with PerfectIdealGas gas model, then the cp, cv, gamma, h0... should not ask for a temperature.

combustion_thermodynamics.Combustion() #() allows gas mixtures for both fuels and oxidizers. In case of the fuel mixtures, it is not already developed, but in the case of the oxidizers mixtures, the reactants do not consider O2 in the mixture.

Although there is a vast amount of species in the Nasa Glenn thermodynamic properties, it can be useful to define a new gas and use it as a Perfect or Semiperfect Ideal gas.

This feature should replicate a PerfectIdealGas or SemiperfectIdealGas object but with customized data.

Create a new notebook with examples of usage for the Combustion class

Juypyter notebooks with example to illustrate basic features of pyTurb:

• ISA
• PerfectIdealGas
• SemiperfectIdealGas
• ThermoProperties
• GasMixture
• IsentropicFlow

Use pytest and numpy.testing to create tests for pyTurb.

Whenever a Combustion() is initiated, the fuel and oxidixer proposed for the combustion are checked within a list that is hard-coded at Combustion.__init__. The list is very limited and the species name do not coincide with the name of the gas in PerfectIdealgas or SemiperfectIdealGas.

The list of accepted fuels and oxidixers should be expanded and it should be enough to provide the basic chemical formula instead of the name at Nasa Glenn file. I.e:

• There are 8 species (isomers) of the butene (C4H8):
  • C4H8,1-butene
  • C4H8,cis2-buten
  • C4H8,tr2-butene
  • C4H8,isobutene
  • C4H8,cyclo-
  • C4H8(L),1-buten
• The __init()__ in Combustion checks that the literal gas species name is among the allowed fuels
• Thus the 8 different species should be listed among the allowed fuels in order to make use of them

It would be more efficient to search for the basic formula instead the complete literal, i.e. search for 'C4H8' instead of 'C4H8,1-butene'

Use np.power to calculate cp in SemiperfectIdealGas class when temperature is provided as a temperature. Now the user must create a for-loop and provide one temperature (discrete value) at a time.

VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences at pyturb.gas_models.height_from_temperature_isa

Spike value when you use cp(i) with i = 1000, (K)

\ \
from pyturb.gas_models import SemiperfectIdealGas
import numpy as np
import matplotlib.pyplot as plt

t = np.linspace(200,3000)
cp = []
for i in t:
cp0 = semiperfect_air.cp(i)
cp.append(cp0)

plt.xlabel('K', fontsize=15)
plt.ylabel('c_p', fontsize=15)
plt.plot(t, cp)
plt.grid(True)
plt.show()
\ \

Craete a function to calculate the stoichiometric adiabatic flame temperatura of a reactive mixture in Combustion().

Some of the calculations here such as isa and isoentropic flows can be found also in scikit-aero:: //github.com/AeroPython/scikit-aero#usage

Maybe you can find some inspiration there or can contribute with something 😃

Declare initial pressure and temperature of the combustor and the initial temperature and density of the reactants. Create it as new class properties and create a function to write the values.

Create and pass tests for:

• Stoichiometric coefficients of the combustion
• Products dictionary
• Stoichiometric Fuel-Air Ratio
• Fuel-Air-Ratio when rich or poor combustion

Those tests cover the features developed at Combustion since today.