Comments (6)
Thanks for looking into it so quickly 🚀
Not sure how (yet), but seems ctop
is able to not show anything when viewing its own logs through their UI. Probably they do some heuristic detection for this as well (like checking that the image has a specific name or the ENTRYPOINT is a specific value).
I'll let you know once I find out how ctop does it, so maybe we can copy the method for oxker.
from oxker.
build for v0.1.5 correctly updated the dockerhub image, so closing now, thanks
from oxker.
This sounds interesting, I have set up a dockerhub account, but have never published to it before.
How would you envision the docker container being created? And how could I test that on my home computer.
Even though oxker is based around Docker environments, I am clearly lacking some knowledge regarding it all.
EDIT: Ok, so I have a basic version running, but I am running into an error, in that when oxker shows the logs for the oxker container (as in itself), I get an out of bounds error regarding a &str. My guess is that the tui terminal characters are playing havoc with the text formatter that oxker is using.
So, will need more time to look at it, or work out how to disable logging for a single container. Or if oxker finds a container called "oxker" it ignores it - but I can imagine all manner of trouble if such a basic, and dirty, method, was implemented.
I'll look at this week and see what I can come up with, will push a new branch, feat/docker, and then anyone can take a look at it.
EDIT 2 : yup, running with docker run --rm ---log-driver none ...
seems to solve the issue, maybe that's the simplest solution?
from oxker.
I can exclude the oxker container from being listed, didn't realise that ctop
did that, and in oxker would be easy enough to do, by just ignoring any container that uses ./oxker
as a command (as in CMD ["./oxker"]
or ENTRYPOINT ["./oxker"]
)
Next up, need to read up on how to create a multi-arch docker build.
Have made a feat/docker branch, with a working example, using a build step and then an alpine runtime step, means the images is only 9mb is size. However, when using alpine, I was unable to correctly get oxker to start, unless I sleep before hand, no idea why, if using a debian-slim container, the sleep is not needed, but the image size jumps up to 80mb.
EDIT: have published this first attempt, based on the feat/docker branch, to dockerhub, should be able to run with docker run --rm -it --volume /var/run/docker.sock:/var/run/docker.sock:ro mrjackwills/oxker:latest
from oxker.
Tried it out today and works like a charm! Thank you so much.
from oxker.
Sounds good, have created a github action to build a multi arch build on each release, so should all be kept up to date without having to think about it now.
I'll close this issue once the next release comes out, and hopefully the Docker Hub image will be updated automatically.
from oxker.
Related Issues (20)
- [BUG] Duplicate log entries
- Track `Cargo.lock` HOT 3
- [BUG] Heading bar loading icon color & position
- [NEW FEATURE] put container name next to Logs title
- [BUG] Malformed escape codes in docker logs causes panic HOT 5
- [NEW FEATURE] Sort columns reset
- [BUG] disable oxker commands
- [NEW FEATURE] Memory column spacing
- [NEW FEATURE] List Port HOT 2
- [BUG] created_at clash
- [NEW FEATURE] long term - detach logic
- [NEW FEATURE] Delete / Remove containers HOT 3
- [NEW FEATURE] Exec Shell - Open a container command line HOT 5
- [BUG] GHCR build issues HOT 1
- [BUG] Unable to access docker daemon HOT 10
- [NEW FEATURE] about column layout HOT 9
- [BUG] - Memory displayed incorrect HOT 3
- [BUG] issue freeze when click on CPU to show from high to low HOT 6
- [BUG] unwrap err on rebuild
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oxker.