mrdarcymurphy / node-rmrf Goto Github PK

Hi!

I'm trying to use your module with typescript 3.4.5, I think that the types for this module are not correct, concretely you have:

declare namespace rmfr { type Options = rimraf.Options & { glob?: rimraf.Options["glob"] | true; disableGlob?: never; }; }

This will never accept glob: true as an option, so, right now I'm using:

declare namespace rmfr { type Options = rimraf.Options | { glob?: rimraf.Options["glob"] | true; disableGlob?: never; }; }
I'm not a typescript expert so correct me if I'm mistaken. Hope it helps anyway.

Szz.

Running into a node v4.2.1 compatibility issue here - https://github.com/mrDarcyMurphy/node-rmrf/blob/master/index.js#L4 - with the fs.existsSync method, which has been deprecated - https://nodejs.org/api/fs.html#fs_fs_existssync_path - any thoughts on supporting v4?

The following is the behavior I would expect from node-rmrf:

$ mkdir keep

$ touch keep/important_file

$ mkdir unimportant_directory

$ cd unimportant_directory

$ ln -s ../keep .

$ cd ..

$ ls unimportant_directory/keep/
important_file

$ rm -rf unimportant_directory

$ ls keep
important_file

However, if I use node-rmrf to remove unimportant_directory, it unlinks keep/important_file.

Fortunately, the important file I accidentally deleted wasn't that important (I had a backup), but this is definitely a bug, right? :)

I can provide a PR tomorrow / later today, but let me know if you're interested.