Coder Social home page Coder Social logo

Comments (6)

cseickel avatar cseickel commented on May 29, 2024 1

So far so good. I really like the "there are x unprocessed" message, that's a nice touch. I'll keep using it throughout the work day and let you know how it works out.

from neo-tree-diagnostics.nvim.

mrbjarksen avatar mrbjarksen commented on May 29, 2024

I'd be happy to add a config option for this, although I'm more worried about the performance. How many diagnostics can the source handle before freezing, and how long is the delay? Maybe making the refresh function async would be worth the effort?

I'll add an option in the meantime, at any rate. I'm thinking refresh_delay for the debounce and refresh_event to adjust when it fires.

from neo-tree-diagnostics.nvim.

cseickel avatar cseickel commented on May 29, 2024

How many diagnostics can the source handle before freezing

That's a good question! I don't really know because it's frozen. I had also thought about adding a limit for the number of diagnostics, like if there are more than 100 or 1,000, just bail out with a warning.

The type of thing that could cause the problem is changing a core data provider class that is used throughout the project in a way that breaks it in typescript. I just did that as a test and it produced 263 errors. I'm guessing there is a problem where as I'm typing, it's producing 263 errors on every keystroke. Or maybe I did something that produced more with a certain edit. 🤷🏼

from neo-tree-diagnostics.nvim.

mrbjarksen avatar mrbjarksen commented on May 29, 2024

@cseickel I just added the options refresh.delay, refresh.event and refresh.max_items on the branch refresh-config. Can you confirm this works as expected before I merge?

from neo-tree-diagnostics.nvim.

cseickel avatar cseickel commented on May 29, 2024

I think it works perfectly, I'd say it's good for release. 🚀

Thanks!

from neo-tree-diagnostics.nvim.

mrbjarksen avatar mrbjarksen commented on May 29, 2024

Great, thanks!

from neo-tree-diagnostics.nvim.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.