Error in event handler for event neo_tree_buffer_enter[diagnostics.neo_tree_buffer_enter]: .../lua/nui/tree/init.lua:254: Expected Lua number about neo-tree-diagnostics.nvim

[cseickel]

@nyngwang The event handler I gave you assumes that you are only using the filesystem source and will not have any other sources open. It needs to be re-written to be aware of which source triggered the event.

Maybe auto-preview does need to be handled in core, even if it is enabled and/or configured per source.

[mrbjarksen]

My apologies, I don't know how I didn't notice this. I'm working on fixing it but I'm having trouble seeing what's happening.

Are you sure that autopreview = false also gives an error? I'm not seeing the same thing.

[nyngwang]

@mrbjarksen I also made this issue in a hurry. Here is the missing context that I consider the culprit to this issue:

event_handlers = {
  {
    event = 'after_render',
    handler = function ()
      local state = require('neo-tree.sources.manager').get_state('filesystem')
      if not require('neo-tree.sources.common.preview').is_active() then
        state.config = { use_float = false }
        state.commands.toggle_preview(state)
      end
    end
  },
  -- some other events.
},

and regarding my aforementioned testing on neo-tree-diagnostics.nvim side, I have tried with or without the commented-out config:

diagnostics = {
  autopreview = false,
  -- autopreview_config = { use_float = false },
  -- autopreview_event = 'neo_tree_buffer_enter', -- also tried changing it to 'after_render'. Also got an error.
  window = {
    mappings = {
      ['<cr>'] = function (...)
        local cur_win = vim.api.nvim_get_current_win()
        require('neo-tree.sources.diagnostics.commands').open(...)
        vim.api.nvim_set_current_win(cur_win)
      end
    },
  },
},

(if a better title can be used, please let me know. I'm not sure whether or not you can change it.)

[mrbjarksen]

I just pushed a commit which fixes things on my end (9a78e75). If it doesn't work for you, try disabling your event handler, the interplay between them might be causing issues.

[nyngwang]

I still got the error if I keep the event as above.

Error in event handler for event after_render[table: 0x01034d1148]: ...im/site/pack/packer/start/nui.nvim/lua/nui/tree/init.lua:254: Expected Lua number

[...] If it doesn't work for you, try disabling your event handler, [...]

But then I will assume that the ability to preview on filesystem source will be disabled. Do you have any alternative regarding that?

[nyngwang]

After some testing I think this will be helpful: If I call the toggle to open diagnostics.nvim when my cursor is at neo-tree, then no error will be shown.

[mrbjarksen]

Maybe auto-preview does need to be handled in core, even if it is enabled and/or configured per source.

Yes, I think that would probably be a good idea. My solution was more involved than I originally thought it would be.

[nyngwang]

@cseickel Then maybe this could be put into a new issue on neo-tree side and feel free to postpone it if there are issues of higher priority. I'm happy to know that this bug is indeed triggering the improvement of neo-tree to be a more powerful daily tool :)

[...] If I call the toggle to open diagnostics.nvim when my cursor is at neo-tree, then no error will be shown link

I will use this as a workaround and wait for the update.