mrbellek / mvc Goto Github PK

lol dutch

Error page function is partially disabled at the moment, for causing infinite redirect loops under certain conditions.

Error page should be working for these situations:

• controller for url doesn't exist
• model for url doesn't exist
• action for url doesn't exist
• template for url doesn't exist

Some models are logging in users, changing sessions, calling other models. That shouldn't happen there. Delegate to Controller and/or centralized functions.

Currently the logged-in user is saved in the session. This is done in the Login model and Register model. This is both the wrong place, and not centralized. Create a helper that can read/write to the current session.

PHPStorm keeps complaining. Make some dedicated exception classes for stuff.

There's already a spot for ROLE_ADMIN or similar in table user.roles (json-encoded roles array). Not sure how to create a new admin, unless you're already an admin yourself.

Admins should be able to create other admins or users. Maybe change users' passwords.
The 'this user is an admin' checkbox should ONLY appear for admins. Validate this by session, not by post data.

The Mailer helper class was implemented in #2. PHPMailer supposedly has built-in SMTP capabilities, so it'd be nice to have the MVC framwork capable of sending email out-of-the-box.

It's in composer.json and there's a Cache class. No idea if it works properly. Not sure if I can set it up on Windows.

Framework should be able to send emails. Look into PHPMailer library.

To be used e.g. by 'forgot password' function, or welcome email after registration.