mrantares / robrowserlegacy Goto Github PK

The packet removes pushcart when there is a state update.
After reloging the pushcart is back again as it should.

EG: If a bard attacks with bow it should use a separate animation from the one that is attacking with instrument.

This applies to all weapons that have separate attack animation.

Currently, only the job default attack animation is shown.

Does not work when casting directly, sprinting and casting, when combo casting after tumbling activated.

We should be able to use skills on names in the party/friends window and doing so should cast the skill on the selected player if it is visible on screen and there is a valid path to it, just like casting the skill normally.
This is a great official feature to use in crowded situations like woe or large parties where it is difficult to click on party members directly.

Currently, the displayed pushcart is only a placeholder (displayed always behind the player), the proper pushcart behavior is not implemented (dragging it like a separate entity).

Animation delay is not implemented on client side, so skills can bypass it completely, like sonic blow and cross impact.

is missing.

Some effects has to travel from the caster to the target or connect them.

Example: Frost Driver, Fireball, Jupitel Thunder, Soul Strike, Sacrifice (Crusader), Grimtooth, Dark Strike, Drain skills, Marionette Control, Shadow Form

Might be related to #7

Quitting or returning to character selection leaves the character online often (but not always).

Can't seem to point out the issue, since the packets are sent and the confirmation is received (according to log).
Might be a network issue, because some skills also hang sometimes, like Teleport.

Some skills like bowling bash sometime causes entity attachments to get offsetted and they remain that way. For example emoticons and the targeting triangle appear shifted to the east instead of above head. This is somehow related to the addition of configurable position to entity attachments.

Skill window tree view is missing

I guess this needs to be implemented as well.

• When the character is at 10,20,30..100% exp (percent rounded to 1 decimal)
• Read msgstringtable for the proper 3 lines of text (one of the parts is a 2 parter, because it should contain the character name)
• On the following text that can be anything, send the packet if the text was okay.
• Step3: $PROFIT$

This buff can be pretty important in SN gameplay.

Guild skill window is missing

The camera has to be restricted in height and angle when being on an "indoor" map.
The property is defined by data\indoorrswtable.txt

Game-breaking animations are missing:

• Spiritball, coin, elemental balls, etc..
• Warp portal(skill)
• Warp portal(map)
• Ground effects that show path or other quest related things (yggdrasil dungeon, new world)
• Crimson marker

Most of the class-related stuff is coming from the data files, so there is far less hardcoded things in this client, but still, some 4th job related contants and other codes are needed to be added.

..is missing.

Homunculus, Mercenary, Pet, Elementals and similar things are not implemented, and thus are unusable and could lead to loss of minion, due to unable to feed.

Is missing. I believe this is for only clients&servers going up from a certain version/date, but I have absolutely no info on this matter and never saw it work either, since our server stopped at packet ver 2012.04.10

Intravision (maya purple) is not removed after character change.

Mail support is missing

Effects should be ordered based on their distance to the camera and rendered from back to front, so that transparent effects can be rendered properly.

Same story with sky, water, sprites+sprite effects (entities) and effects. Since all of these rendered separately there should be something like a global rendering queue ordered by distance or something else clever. Right now there is a fixed order, but this doesn't work when there is transparent water + transparent sprite + transparent effect on top of each other. All of them should add together in transparency even if they are placed in reverse order from how they are rendered. Now in this case the first to render cuts out the later ones if they are behind it.

The solution shouldn't be resource intensive!

They has to use SpriteRenderer instead of the built-in one, since these effects has to turn with the camera and look the same from every angle. Now they are projected horizontally into the 3D space, which messes up their appearance when turning the camera.

Hello there. There wasn't any other way to contact you direclty via mail so I opened a new issue.

The installation guide is outdated, there is ie. no api.html anymore. The build tools for compiling aren't there anymore. Also the index.php from the client folder is missing.

I was hoping to get roBrowser working, but seems impossible with the currently available installation guide.

Could you provide any help to set it up, please?

ALT-M shortcuts window is missing

Does not display taekwon mission information

Surprise! But, yes, it is missing as well.

The menu for configuring battlemode keys is missing

Screenshot exports a black image

The Doram race and it's classes/skills/etc are missing. Also, this needs a GUI update to include Doram specific elements.

A lot has been fixed in the path finding. The only remaining issue seems to be that when the target is snipable, but there is no direct walkable path, and the target is out of range, for some reason the calculated path leads directly to the target's cell and not into a closer snipable position that is in range.

If an entity dies from a skill that has '3D' type effect, the effect is instantly removed.
The effect should play normally whether the entity is removed or not. Even if the entity is attached, it should remain at the last position.

The flying arrow animation is missing when attacking with bows

Orc lord broke my shield and every weapon vanished from the hotkey bar. After repairing the shield they returned instantly. Funny stuff :D

are missing.

Added a Granny module for later use in:
53f151c

is missing

The skill hotkey bar resets to highest skill level available for each skill whenever a skill is added to the tree (eg via equipment change).

Trying to connect to fresh rAthena and i've got an error

Packet "0xac4" not register

most likely it happened because I have a packet version more than 20170315

rAthena's loginclif.cpp:

#if PACKETVER < 20170315
	int cmd = 0x69; // AC_ACCEPT_LOGIN
	int header = 47;
	int size = 32;
#else
	int cmd = 0xac4; // AC_ACCEPT_LOGIN3
	int header = 64;
	int size = 160;
#endif

something has changed in the authentication algorithm

Description

This bugs makes robrowser's screen black, and it starts to spam this error message when tries to render :
https://i.gyazo.com/ef8157768f2276d4fc71d20f63817c4f.mp4

How to reproduce

To reproduce the bug i only need to scroll down/up quickly and it starts to happen.

If the camera is not at the default position, the effect textures have different angle from what angle they should be at.
Eg: Meteor assault effect textures rotate when rotating the camera :D

Taming is missing

are missing.

Related to #51

Opening a shop is not working after items are added to the list and hit ok.

Warp portal effect should be the entity itself, and not a map effect like now.
Because of the current behavior temporary portals like airship portals don't vanish when the entity itself disappears.

Names that contain spaces are not sent, because the packet is sent without the spaces and thus the server sends "Recipient does not exist"

Example:
Target name: Test Name
Packet is sent like: TestName

are missing effect & sound.

is missing

Like using an area skill and meanwhile receiving damage changes the displayed damage that you receive to the number you deal to the enemy. Tis is only a displayed number error, you don't receive the damage.
This works vica-versa. Sometimes the damage you deal is displayed as "miss" while you actually landed the hit and the enemy is the one who missed the attack.

3DEffect works for Endure and Heal but doesn't work for Sight and Runwatch.
GroundEffect doesn't work for warp portals.

Needs further testing and fixing.

Needs to display a random line from the ba_frostjoke.txt / dc_scream.txt file from the data folder either in the GRFs (default) or the client/data folder on the server, or if the player dragged a custom data folder into the client then that. The latter part is already handled by the file manager, so only need to request the file :)

..is missing