Coder Social home page Coder Social logo

mralek / awpercentdriveninteractivetransition Goto Github PK

View Code? Open in Web Editor NEW
129.0 129.0 22.0 11 KB

A drop-in replacement for UIPercentDrivenInteractiveTransition for use in custom container view controllers.

License: MIT License

Objective-C 89.03% Ruby 10.97%

awpercentdriveninteractivetransition's People

Contributors

mralek avatar readmecritic avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

awpercentdriveninteractivetransition's Issues

Flashing when canceling animation

flashing (flickering) occurs when canceling animation (returning to current view controller),
something like showing next view controller for milliseconds - and then hide it

How it can be prevented?

thaks

'completionCurve' is ignored

It seems that completionCurve in ignored in the current implementation (it always seems to uses a linear curve when completing the transition animation). It'd be nice if we could use the easy in out curve for completion (while keeping the linear one when interacting with the transition).

Wrapped animator reports completeTransition:YES to context even when cancelled

Since the animation controller is unaware of being wrapped in AWPercentDrivenInteractiveTransition, it will always call completeTransition:YES to its transition context, even when the transition is cancelled and the animation is reversed. This can cause issues in certain contexts.

Potential solutions

  • Swizzle completeTransition: on the context and catch up when called by the animator. Of course, swizzle back to original implementation once transition is over.
  • Make AWPercentDrivenInteractiveTransition call completeTransition:NO itself. It would be run several times though :/

Swift

I ported the project to Swift here. I am about to integrate it into my project, and start testing.

Since I thought it doesn't make sense to have two implementations, I decided to remove the ObjC stuff. I suggest, if you like, to merge this into a new branch.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.