mpfeifer1 / piano Goto Github PK

It can probably be almost identical to a note signal i.e.

rest_signal = { type : rest, length_num : X, length_denom : Y }

Literally what's the point of writing a song if you can't write it in HELICOPTER?
Add all the instruments to the grammar.

All variables should follow some sort of naming convention
All methods should also follow a naming convention

All code should have some sort of commenting if it needs it

Make sure all the code and comments are professional cough michael cough

Research which language we should use for PIANO. Also, research tools and language grammar.

Add things like how to run the unit-test enabling script, and how to compile code in our language, etc...
This may be a lot of copy-pasta from the user manual, but we need something here

This will need to be implemented in both SemanticAnalyzer and in MidiGenerator

We should have the different functionality split into folders. Additionally, we may want to rename the files to be consistent, and be a little more accurate to what they do. For instance, we should rename 'ourtests' to something more professional, and when we make more unit testing files, toss those into the unit test directory as well.

When the user passes in broken code, it should be obvious what they did wrong

In semantic.py, make sure all of the x_to_signal are checking before they go in. Some already are, get the rest of them.

Docker containers may not be the way to go, actually.
We may want to look into zipping up python, lark, mido and whatever other libraries.
This way, we'll be able to give users an easy-to-use package that will let them compile code with absolutely no effort.