Collapse/Expand results per rule (and per file) about scanjs

[mozfreddyb]

@pauljt suggests this might also be a "check list" feature, where you tag results as "this is indeed an issue", "this is not an issue", "this is a false positive", and "I haven't looked at it yet"

[mozfreddyb]

I will tag this for milestone 1.0, but it might be optional.

[mozfreddyb]

AngularJS allows us to filter a table.

I'm not going to add this because I find the current table output thing quite horrible, but cannot make up a better proposal.

[pwnetrationguru]

We have filter by rule and filename, closing.

[mozfreddyb]

Filter is not sort. I was suggesting to hide certain results see this example: http://docs.angularjs.org/api/ng/filter/filter

[pwnetrationguru]

Ah ok, my fault, reopening. Feel free to take :)

[pauljt]

@mozfreddyb Did you see the filtering that I added? There is a list of rules in the sidebar. You click them, and it filters the results in the table. Its like a search filter, where you can type free text - is that what you mean with this issue? Just wanted to make sure that you were aware that it does already filter. There is no sorting, as far as I am aware, unless someone else added that.

[pauljt]

typo: Its NOT like a search filter...

[pwnetrationguru]

You can sort whatever collection of results you are viewing.

So if you are viewing a filtered set, you can sort based on rule name and line number, if you are viewing the entire result set you can filter based on filename, rule name and line number by clicking the headings in the table.

I think you added it, @pauljt! :)

[pauljt]

Ah no I remember now, that might been me, I think it might have been freddy though. I'm just trying to understand what freddy means above when he says we need to add filtering? I do think we can improve on the table, but it works for now.

[mozfreddyb]

Sorry, I misunderstood how it worked. Thanks for the clarification! We can close this now ;)