Comments (5)
Hmm interesting, thanks Rob!
Actually I'm not even sure how thes rule even works - I don't remember adding support for xxx.yyy.zzz
Interesting that a.hide() doesnt get flagged but a.hide does.
Another reason for abandoning the rule parser, and going back to explicit rules imho. (though the fix for this specific case should be simple)
from scanjs.
Thanks for filing, Rob! :)
This is probably bad for other users of jQuery. Would you be willing to take a stab at it?
The rule parsing code is likely to be changed completely in the future by #168.
from scanjs.
@mozfreddyb, I can definitely take a look, although the parsing engine has always been a bit of a black box for me. :)
Any idea on priority of getting #168 done?
from scanjs.
If this here is important for you, I'd recommend you take a look before we get at #168.
from scanjs.
Cool, sounds good. I'll take a look this week! I'll probably follow-up with questions as I go.
from scanjs.
Related Issues (20)
- Bug: "new foo('arg')" matches "new foo()" which results in false positives HOT 1
- Create rule with data type of argument HOT 6
- False positives for literal assignments HOT 2
- Need a better structure for JSON reports in the cmdline version. HOT 2
- JS parsing and AST generation should be easier to switch out. HOT 4
- Support for longer rules (e.g. foo.bar.baz) HOT 1
- split scanjs into separate repos for nodejs, web and just the scanning HOT 3
- Investigate and complete automated deployment gh-page updates through Travis-CI HOT 1
- experiments tab is broken
- show parse errors on experiment tab
- "use strict"; mode wherever possible
- package missing from npm registry HOT 7
- Rule Parser Rewrite (Redux) HOT 1
- Incorrect line number reported in output json file HOT 2
- [Feature Request] Export results to HTML
- checklist: add comment/hide/delete button in output view
- Sources Rules a='b'; HOT 2
- Rule for values inside object? HOT 3
- Wiki changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scanjs.