Comments (6)
Luckily, this issue wouldn't need any rework on the scanning/upload handling. Currently, we would already scan multiple files, but a second file just overwrites previous results & editor content
from scanjs.
Done!
from scanjs.
So looks like this landed in master and ended up breaking a few things; another reason we need these tests!!! :) Also, there are conflicts with the previously existing PR #31.
In master, the client interface's CodeMirror instance is broken. It does not load our examples and I cannot manual input code into the code mirror.
Upon hitting scan, I get the following error:
Error: $scope.inputFiles[0] is undefined ScanCtrl/$scope.run@http://people.mozilla.org/~rfletcher/scanjs/client/js/scanctrl.js:11 Za.prototype.functionCall/<@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/angular-1.2.13.min.js:164 Pc[c]</<.compile/</</<@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/angular-1.2.13.min.js:181 Cd/this.$get</h.prototype.$eval@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/angular-1.2.13.min.js:103 Cd/this.$get</h.prototype.$apply@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/angular-1.2.13.min.js:104 Pc[c]</<.compile/</<@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/angular-1.2.13.min.js:181 o.event.dispatch@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/jquery-2.1.0.min.js:3 o.event.add/r.handle@http://people.mozilla.org/~rfletcher/scanjs/client/js/lib/jquery-2.1.0.min.js:3
...{return typeof o!==U&&o.event.triggered!==b.type?o.event.dispatch.apply(a,argume...
We should probably back these changes out, fix the errors, and then submit a PR. jmo though, I definitely don't want to be bullheaded so please let me know your opinions @mozfreddyb and @pauljt on how best to handle.
In my opinion, in the future we should follow this process before merging into master:
- Tests pass - once we have them :)
- push dev branch and create PR describing the changes, etc.
- Get at least 1 LGTM from someone on the project
- If no conflicts, merge into master
- If conflicts, resolve conflicts, run tests
- Assuming no major changes, merge into master, else update PR.
Again, not trying to lead this development process in any one direction, just trying to figure out what we all agree on. :)
from scanjs.
It's not broken, its a feature! :) You have to load a file first now. I'll add some checks.
from scanjs.
well if it still breaks things, we want to back out :|
from scanjs.
I think this was fixed with commit 58cf6cb. Close this, @pauljt?
from scanjs.
Related Issues (20)
- Bug: "new foo('arg')" matches "new foo()" which results in false positives HOT 1
- Create rule with data type of argument HOT 6
- False positives for literal assignments HOT 2
- Need a better structure for JSON reports in the cmdline version. HOT 2
- JS parsing and AST generation should be easier to switch out. HOT 4
- Support for longer rules (e.g. foo.bar.baz) HOT 1
- split scanjs into separate repos for nodejs, web and just the scanning HOT 3
- Investigate and complete automated deployment gh-page updates through Travis-CI HOT 1
- experiments tab is broken
- show parse errors on experiment tab
- "use strict"; mode wherever possible
- package missing from npm registry HOT 7
- [false-positive] input-manage permission rule HOT 5
- Rule Parser Rewrite (Redux) HOT 1
- Incorrect line number reported in output json file HOT 2
- [Feature Request] Export results to HTML
- checklist: add comment/hide/delete button in output view
- Sources Rules a='b'; HOT 2
- Rule for values inside object? HOT 3
- Wiki changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scanjs.