web workers console.log causes error about scanjs

[pwnetrationguru]

We could also add a simple boolean argument to ScanJS.scan() that simply tells it whether or not we want to print to console. That might be hacky tho.

[mozfreddyb]

We cannot use console.log inside a web worker, it causes console not defined errors.

Works for me in Firefox 29+, currently Aurora
I'll test what the spec says and come up with a solution. Happy to take this bug.

[pwnetrationguru]

Yah, I'm on FF 28.0 currently on this machine.

It does seem console.log with web workers has been a known issue for a while, but maybe browsers have updated since the articles I'm reading.

Just to be sure, you've cleared your cache?

[pwnetrationguru]

Anywho, I also don't mind turning off console.logs() for the client interface anyways and just use them in the server version, so maybe an additional parameter to scan() is the way to go but obviously whatever you think is best

[mozfreddyb]

I don't think there's any benefit in disabling too many console.log calls. For end-users it's hidden away anyway, because you'd need to activate the devtools and then you're not just a user anymore ;)

I would suggest shimming console in the worker with something like this:

DEBUG=false;
if (typeof console === "undefined") {
  console = {};
  console.log = function consoleShim() {
    if (DEBUG === true) {
      postMessage(arguments.join(" "));
    }
  }
}

DEBUG is probably not the right name, as the worker will always print stuff, if console is available in the worker.

WDYT?

[pwnetrationguru]

That seems like a reasonable approach! I'd even be fine leaving out the DEBUG check and just printing, although I suppose there could be performance implications of that.