mozilla / make-valet

INACTIVE - http://mzl.la/ghe-archive - NodeJS application that hosts details for your makes

Make Valet

NodeJS application that hosts details for your makes.

Quick start

1. Clone this repository via git: git clone https://github.com/mozilla/make-valet.git
2. Change directory to the repository: cd make-valet/
3. Install bower if not already installed: npm install -g bower
4. Install dependencies: npm install
5. Copy default config to working location: cp env.dist .env
6. Edit config file with your favourite text editor. See comments in config file for what each option does
7. Run the server: node server.js

Running make-valet without an Internet connection

make-valet relies upon the xip.io domain to access user subdomains. If you do not have an internet connection available, you'll need to have some other way of setting domains on your local machine.

Edit your /etc/hosts file

For example, if I'm the user jon, you'll need to add an entry for jon.127.0.0.1.xip.io to your local hosts file:

127.0.0.1 jon.127.0.0.1.xip.io

The downside of this approach is that you'll need to add a hostname for each user you create locally.

Run a local DNS resolver

If you're running the make-valet offline with a number of users, you should use a local DNS resolver like dnsmasq to scale up to any number of users

make-valet's Issues

Wiki changes

FYI: The following changes were made to this repository's wiki:

• defacing spam has been removed

• the wiki has been disabled, as it was not used

These were made as the result of a recent automated defacement of publically writeable wikis.

CODE_OF_CONDUCT.md file missing

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please reach out to [email protected].

(Message COC001)

Commit locales folder

They're not gonna change, and complicate things on Heroku.

Not compatible with node 4

According to @cadecairos in #69, make-valet is currently not compatible with node 4. We should get it working so we can stay on node LTS versions.

Decide what to do with the make details bar

This thing....

....is currently an iframe that is served from webmaker.org. This was originally done to allow for actions that required a user session (favoring and reporting). We won't need that anymore.

We have two options:

a) re-implement it and render it from make-valet

b) remove it entirely

@ashleygwilliams @jbuck @xmatthewx @simonwex

Double scrollbars

Im seening double scrollbars in Thimble and other places and was told the problem is with make-valet.
https://github.com/mozilla/thimble.webmaker.org/issues/468

So could someone either make the iframes block level or if it has to be inline, make it vertical-align: bottom, so that the extra scrollbar goes away.

vertical-align: bottom;
display: block;