mozilla-extensions / devtools-adb-extension Goto Github PK

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)

FYI: The following changes were made to this repository's wiki:

• defacing spam has been removed

• Restricting write access to contributors is strongly encouraged. Please make that change (documentation).

These were made as the result of a recent automated defacement of publically writeable wikis.

Right now the repository name is "devtools-adb-extension", but the extension's name "ADB binary provider". For consistency I would like to rename the extension to "ADB Extension" or "DevTools ADB Extension".

Ultimately this extension might be hidden from about:addons (once we have a satisfying way to add/remove the extension from DevTools UI). But it would still be nice to agree on the name.

@hiikezoe @birtles objections, suggestions?

Do it is possible to use this extension from other extension to get devices and execute shell command?

We should have a short description of the extension in this repository.

I noticed this as part of reviewing https://phabricator.services.mozilla.com/D160057 (part of Bug 1797050) and so I thought to file this followup upfront:

In MV3 we plan to fully deprecate "applications" from the manifest.json, in favor from the other alias "browser_specific_settings" (which we support from quite a long time and so it should be backward compatible enough also with older Firefox versions) and so we may change the template-manifest.json part of this repo to make sure we migrated the adb addon away from it ahead to its future deprecation.

The diff to apply the change describe above would look like in the following diff:

diff --git a/extension/template-manifest.json b/extension/template-manifest.json
index 8888843..f0a47ab 100644
--- a/extension/template-manifest.json
+++ b/extension/template-manifest.json
@@ -4,7 +4,7 @@
   "author": "Mozilla & Android Open Source Project",
   "version": "@@VERSION@@",
   "description": "An extension providing ADB binaries for Android remote debugging in Firefox DevTools. May be automatically installed when using about:debugging.",
-  "applications": {
+  "browser_specific_settings": {
     "gecko": {
       "id": "[email protected]",
       "strict_min_version": "64.0a1",

NOTE: the template-updates.json file also includes an "applications" property which SHOULD NOT be changed to "browser_specific_settings", for that one Firefox doesn't yet support any alias named "browser_specific_settings" and unfortunately its named and its format looks basically the same as the manifest.json one which may be confusing and so I'm calling it out explicitly in this issue to make sure we don't mistakenly change that one along with the manifest.json one.

Once bug 1481691 landed, we use the manifest file for this extension (i.e. manifest.json on the root directory) for version comparison, so we don't need each manifest.json in linux/, etc.

The license for the extension is currently missing. Can we please add it?

Similarly to the current adbhelper, we should have signing and release scripts, as well a release documentation.

The fastboot files are no longer listed in adb.json. Should they be removed from this repository?

I can't see any code to support fastboot in https://bugzilla.mozilla.org/show_bug.cgi?id=1469054 so I assume we are removing the support for this feature?

Feature was added for privileged addons in https://bugzilla.mozilla.org/show_bug.cgi?id=1365349

STR:

1. Install Firefox DevTools ADB Extension in Firefox Nightly (by visiting Tools | Web Developer | WebIDE -- this causes the extension to suddenly appear in your list of installed addons).

2. In a new tab, visit about:addons and click "extensions"
   --> Note that Firefox DevTools ADB Extension is tagged as ALLOWED IN PRIVATE WINDOWS

3. Click the addon to view its settings, and try to click radio button labeled...
   "Run in Private Windows: ... [] Don't allow"

EXPECTED RESULTS: Click should be honored, "Don't Allow" should be selected.
ACTUAL RESULTS: "Don't Allow" is only selected very briefly, and then "Allow" becomes selected again.

There doesn't seem to be any way to select "Don't Allow". You can get it selected for slightly longer if you Disable the addon and then pick Don't Allow while it's disabled, but once you reenable it, then "Allow" becomes selected on your next (re)-load of about:addons.