moxystudio / next-pre-compression Goto Github PK

Currently, an assetPrefix that contains an absolute URI like https://cdn.my-website.com is not supported.

To support it we must account for these types of assetPrefix

1. absolute path like /foo ✅
2. absolute URI like https://cdn.my-website.com ❌
3. absolute URI with paths like https://cdn.my-website.com/foo ❌

To support 2 is easy, we just need to detect that pattern and assume an empty assetPrefix. However, 3 can be either mounted with an empty assetPrefix or an assetPrefix of /foo depending on how you setup proxies/load-balancers.

My suggestion is to have a default behavior of assume an empty assetPrefix on 2 and 3 but be customizable through a assetPrefix option.

If you are in the need of supporting absolute URI as the assetPrefix please do a PR that implements the suggestion above. ❤️

We are using koa now in our boilerplate, but we are still missing the middleware.