moust / silex-cache-service-provider Goto Github PK

Hi,

I followed the doc, so here is my bootstrap :

$app['cache.options'] = array(
    'driver' => 'redis',
    'redis' => function() {
        $redis = new \Redis();
        $redis->connect('myserver', 6379);
        return $redis;
    }
);

Doesn't work...

And when I launch my debugger, at this line in RedisCache.php

if (!isset($options['redis']) || !$options['redis'] instanceof Redis) {
    //default connection
}

The debugger goes inside the loop ... And it shouldn't go inside
Because the closure never called.

I think the code should be something like :

if (!isset($options['redis']) || !is_callable($options['redis']) || !$options['redis']() instanceof Redis) {
   //default connection
}

Same code for the other providers but i didn't try them.
What do you think ?

Supports silex ~2.0

In FileCache class, the exists function always returns false.

The fetch function, expects the cache key, but in the exists function, the filename is passed to the fetch function.

So

public function exists($key)
{
    return !!$this->fetch($this->getFileName($key));
}

Should be changed to:

public function exists($key)
{
    return !!$this->fetch($key);
}

Earlier everything worked, but now 1.0 also want pimple 3.0, while silex 1.3 use pimple 2.0.
How to fix this?