mostjs / sample Goto Github PK

The typescript definitions should have a fallback case for when the current scenarios can not be met.

sampleArray<A, C>(f: (...input: Array<any>) => C, streams: Array<Stream<any>>): Stream<C>

This is mostly for me to remember to do it :)

I ran into some troubles when using the standalone sample package. Basically both sample versions have slightly different semantics when it comes to order of subscription. For the standalone sampler, the sampler is subscribed to first, then the source.

run (sink, scheduler) {
    const sampleSink = new SampleSink(this.f, this.source, sink)
    const samplerDisposable = this.sampler.run(sampleSink, scheduler)
    const sourceDisposable = this.source.run(sampleSink.hold, scheduler)

    return new SampleDisposable(samplerDisposable, sourceDisposable)
}

while in the other sample it seems that the source is connected to first :

Sampler.prototype.run = function (sink, scheduler) {
  var l = this.sources.length
  var disposables = new Array(l + 1)
  var sinks = new Array(l)

  var sampleSink = new SampleSink(this.f, sinks, sink)

  for (var hold, i = 0; i < l; ++i) {
    hold = sinks[i] = new Hold(sampleSink)
    disposables[i] = this.sources[i].run(hold, scheduler)
  }

  disposables[i] = this.sampler.run(sampleSink, scheduler)

  return dispose.all(disposables)
}

That lead to unexpected behavior on a higher combinator that I am working on. I was able to work around this in two ways, either by directly modifying the standalone sample code to reestablish the desired order, or by forcing the source to connect first, by using drain. Both solutions are sub-optimal however (drain probably means I duplicate flows?, and direct modification of the source code means that a fresh npm install wont get the right version).

What do you recommend :

• forking the standalone operator and npm it under another name?
• harmonize the two sample operators?