morganbarrett / vanilla-semantic-ui Goto Github PK

Describe the bug
An error is show 'targets is not defined' on the click event of titles in accordions.

To Reproduce
Steps to reproduce the behavior:

1. Create an accordion
2. Click on a closed title
3. See accordion not update
4. Check log for error

Expected behavior
Accordion should update to expected state and error should not be shown.

• OS: macOS High Sierra
• Browser: Chrome
• Version: 65

Describe the bug
The mouse out even is called when hovering child elements of the dimmer.

To Reproduce
Steps to reproduce the behavior:

1. Create a dimmer with child elements such as a buttton
2. Hover over the dimmers children
3. See flickering dimmer

Expected behavior
No flickering

• OS: macOS High Sierra
• Browser: Chrome
• Version: 65

can we get a this loaded on CDN

dear Vanilla-Semantic-UI, please keep up the fight for better performance

this is a copy-paste from Semantic-UI issue 6703

Semantic-UI should run faster. jQuery is slow. prefer native JS

Expected Result

run faster

Actual Result

running slow : P

Version

2.4.2

Desc

this concerns the abuse of jQuery.

when i see code like ...

              module.debug('Creating entire dropdown from select');
              $module = $('<div />')
                .attr('class', $input.attr('class') )
                .addClass(className.selection)
                .addClass(className.dropdown)
                .html( templates.dropdown(selectValues) )
                .insertBefore($input)
              ;

in src/definitions/modules/dropdown.js line 360

... i suspect: this cant be fast.

and its not:

• native createElement is faster by factor 4 (or faster by factor 2 if jQuery is needed afterwards)
• native setAttribute is faster by factor 4 (setProperty only works for standard attributes)
• native classList.add is faster by factor 2
• native innerHTML is faster by factor 1.5 (also faster than createDocumentFragment + createElement + appendChild)
• jQuery.html is really slow with 'complex xml input' (innerHTML should be fine, since most pages use XHTML, so strings are parsed as XHTML)

etc ...

templates.dropdown is fast, cos it only concats strings
in src/definitions/modules/dropdown.js line 3900

references

https://ilikekillnerds.com/2015/02/stop-writing-slow-javascript/