mooperd / cloud-control Goto Github PK

Never use "except:" statements without specifying the exceptions you expect.

if is_active is a method, self.is_active will always be truthy even if self.is_active() might be falsy. Making it a property helps with preventing mistakes.

VpcView. the prefetch_related() in line 42 (vpc_instance = ) is completely
unnecessary because you never iterate over the subnet_set on vpc_instance.
Already now there are only two database queries in this method, and it's
hard (and useless) to try and optimize this more (one to fetch the
Vpc instance, and one to fetch all Instance instances)

By convention Django often uses "instance" for the current model instance,
whatever that may be. I'd call these instance_form, vpc_form and subnet_form.