moonpyk / ncuid Goto Github PK

Due to security concerns (which also exist in database auto-increment ids, uuid/guid, and most other id standards), the Cuid standard is now deprecated in favor of Cuid2.

There is a warning when referencing the NCuid package from a net core project:

NU1701	Package 'NCuid 1.0.0' was restored using 
'.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' 
instead of the project target framework '.NETCoreApp,Version=v3.1'.
This package may not be fully compatible with your project.

A new version with netstandard support will be pretty welcome:)

For this line,

Should it be hostname.ToCharArray().Select(c=>c.ToString()) instead?

I tried the existing code and found that it just returned ["hostname"], where hostname is my hostname value.

var ts = DateTime.Now.ToUnixMilliTime().ToBase36();
It should use DateTime.UtcNow here as the Epoch time used is also Utc.

At https://github.com/moonpyk/ncuid/blob/master/NCuid/Cuid.cs#L104, you create a new instance of Random every time the method is called. If I call it in a loop very quickly, then that part of the cuid won't be truly random, as C♯ / .NET seeds Random with the system's clock.

Consider making Random a private static member of the class itself.