Coder Social home page Coder Social logo

molebox / gatsby-theme-pocket Goto Github PK

View Code? Open in Web Editor NEW
40.0 2.0 11.0 3.09 MB

A Gatsby theme that adds a pocket to your website.

Home Page: gatsby-theme-pocket.vercel.app

JavaScript 100.00%
gatsby gatsby-theme gatsby-plugin pocket mobile-integration react

gatsby-theme-pocket's Issues

Deleted articles render as empty articles

After deleting articles from one's Pocket dashboard, they are still returned as part of the response from the Pocket API with a bunch of null fields, and then they render like so:

image

Would be great to exclude these. Again, happy to contribute if you're open to it!

GraphQL query breaks when no articles have an image or any tags

Hey @molebox ! This is an awesome theme, thanks for writing it.

I ran into a couple issues as I got this setup locally.

  1. I couldn't run the yarn pocket-setup script on my Mac at first due to the binary being DOS-based -- I had to delete the file and re-create to fix. It manifests with this error: env: node\r: No such file or directory. Not a big deal but I'm guessing it would scare some people off from using it.

  2. The bigger issue -- if none of my saved Pocket articles have an image or any tags, the GraphQL query in Articles.js breaks:

 ERROR #85923  GRAPHQL

There was an error in your GraphQL query:

Cannot query field "image" on type "PocketArticle".

If you don't expect "image" to exist on the type "PocketArticle" it is most likely a typo.
However, if you expect "image" to exist there are a couple of solutions to common problems:

- If you added a new data source and/or changed something inside gatsby-node.js/gatsby-config.js, please try a restart of your development server
- The field might be accessible in another subfield, please try your query in GraphiQL and use the GraphiQL explorer to see which fields you can query and what shape they have
- You want to optionally use your field "image" and right now it is not used anywhere. Therefore Gatsby can't infer the type and add it to the GraphQL schema. A quick fix is to add at least one entry with that field ("dummy content")

It is recommended to explicitly type your GraphQL schema if you want to use optional fields. This way you don't have to add the mentioned "dummy content". Visit our docs to learn how you can define the schema for "PocketArticle":
https://www.gatsbyjs.org/docs/schema-customization/#creating-type-definitions

File: node_modules/gatsby-theme-pocket/src/components/Articles.js:99:11

I don't have a ton of GraphQL experience but confident I can figure it out. I'm presuming that if there aren't any tags on any articles, the best UI would be to not render the "Filter by tags..." dropdown. Would you agree?
Would you accept a contribution for these fixes?

Thanks and cheers!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.