modxcms / revolution Goto Github PK
View Code? Open in Web Editor NEWMODX Revolution - Content Management Framework
Home Page: https://modx.com/
License: GNU General Public License v2.0
MODX Revolution - Content Management Framework
Home Page: https://modx.com/
License: GNU General Public License v2.0
sottwell created Redmine issue ID 2377
Under certain conditions the getParentsIds function in modx.inc.php can go into an infinite loop, causing a PHP out-of-memory error. This was triggered in a case with two documents in the Tree, one container document in the document root and one child document. Array_search returns either FALSE or the key of the array element found. If the key happens to be 0, as in the parent of the document being processed is 0, then the IF condition will evaluate to FALSE and a value is not put into the $parents array. This can lead to an empty $parents array, which in the final array_merge function where the recursive getParentsIds call is made will cause an infinite loop. The fix is in two parts, one in making an explicit comparison to FALSE in the IF conditional expression, and the other is adding a check for an empty $parents array before the array_merge call. Below is the patched getParentsIds function. getParentsIds function getParentIds($id= null , $height= 10) { $parentId= 0; $parents= array (); if ($id && $height >= 0) { foreach ($ this >resourceMap as $parentId >= $mapNode) { if (array_search($id, $mapNode) !== false ) { $parents[]= $parentId; break ; } } if ($parentId && !empty($parents)) { $parents= array_merge($parents, $ this →getParentIds($parentId, $height-)); } } return $parents; }
splittingred created Redmine issue ID 2349
Messages section needs conversion to 097 and Ext2, as well as some rethinking.
opengeek created Redmine issue ID 2385
The default manager interface needs to now include a transport package management interface with the following features: MODx Software Update Configuration Management Panel
o List of installed transport packages and controls (disable, uninstall, remove)
o List of local transport packages that are not installed and controls (install, remove)
o Package detail panel with version information and package controls (install, disable, uninstall, remove) Package Provisioning Panel
o List of remote package update sites with add/edit/remove controls
- Remote package update site editor panel (dialog)
o Search for New packages to install
o Search for Updates to installed packages
splittingred created Redmine issue ID 2348
Search section now only uses 4 fields. Is that the best we can do?
sottwell created Redmine issue ID 2393
Any time you try to edit or even delete a user, the Editor selection is empty and marked as requiring being filled in. You have to go select “none” again before you can save any changes or delete the user.
rethrash created Redmine issue ID 2386
This would inherit the parent values plus append whatever is included. For example, use it to include basic Javascript in a header section but change a specific page to include an extra bit of CSS as well.
bobray created Redmine issue ID 2358
Double-click launches edit for Elements. It would be less confusing if it did the same for Resources. Single-click could either launch View for Resources or it could launch edit as with Elements.
opengeek created Redmine issue ID 2364
Refactoring the getAuthenticatedUser() function in the modX class to allow a user class to be defined by context settings. This will allow custom user class extensions to be plugged in easily.
bobray created Redmine issue ID 2363
echoed output in a snippet appears at the top of the page rather than at the snippet call location. Document content:
Some text
[ [Snippet Call] ] Snippet content: echo “Hello”;
return “goodbye”; Output: Hello
Title
Some Text
Goodbye
bobray created Redmine issue ID 2356
The grouping of the menu items on the document editing screen seems arbitrary: save | unpublish duplicate delete | preview cancel | options Suggest a vertical bar between all items or none
jrochman created Redmine issue ID 2369
When creating a new category, it becomes a child of all resources (e.g., Templates, Template Variables, Chunks, etc.). There should be a way to create categories that only belong to one of the resources.
opengeek created Redmine issue ID 2366
Web links are broken. Fatal error: Call to a member function processElementTags() on a non-object in C:\dev\xampp\htdocs\modxcms.com\core\model\modx\modweblink.class.php on line 32
bobray created Redmine issue ID 2354
The “configuration” tab (where warnings about config being writable, etc. appear) should be changed to avoid confusion with Tools | Configuration. Suggest changing it to “Site Status” or just “Status”
bobray created Redmine issue ID 2397
The warning message that unsaved data will be lost if you change a document’s template shouldn’t appear if the document was just saved (e.g. not “dirty”).
opengeek created Redmine issue ID 2390
modModule is missing the disabled field, which reminds me that we need to add a disabled property to all element classes, to allow for more options in temporarily disabling specific pieces of content or scripting.
splittingred created Redmine issue ID 2375
Clicking the “New” button doesn’t do anything on the Contexts list view.
splittingred created Redmine issue ID 2374
The Export HTML page currently has not been converted to Revolution.
bobray created Redmine issue ID 2346
To duplicate: In IE7: Click on the MODx News tab.
press Ctrl-F and search for “remember” Top menu disappears and can only be recovered by refreshing the page.
Happens on a similar search on any long page, including editing resources.
bs created Redmine issue ID 2344
Reproduce: create a small snippet that sets a placeholder like this: $modx→setPlaceholder(‘myInteger’,0); now retrieve the myInteger from a document, template or chunk with: [ [+myInteger] ] It will return empty. Same goes for: $modx→setPlaceholder(‘myString’,‘0’);
$modx→setPlaceholder(’myBoolean,false); Probably because getPlaceholder Returns 0.
opengeek created Redmine issue ID 2355
Encapsulate logic currently in login processor within an authentication method in modUser so the logic can be overridden in a custom modUser implementation.
bobray created Redmine issue ID 2359
Resources right-click drop-down menu should include a Preview option as it did in 0.9.6.
bobray created Redmine issue ID 2343
Ideally, users shouldn’t have to fire up an FTP client to rename a file. This could either be another icon in File Manager, or, better, the filename could appear in a field as it does with docs, snippets, and chunks so that a change would be made on save.
splittingred created Redmine issue ID 2388
Neither page has yet been converted to 097. May need to work with 097 packaging support.
splittingred created Redmine issue ID 2379
Update the Ext default styles to MODx-themed styles. Also redo the visual layout of all CSS styles, pretty up the layouts for each section, etc.
bobray created Redmine issue ID 2391
Trying to navigate to a non-existant document redirects to the error document selected in Tools | Configuration in FireFox? but in IE6, generates IE’s standard 404 “Page cannot be found” page (tested only on localhost). — Error pages need to be greater than 512 bytes in size else IE6 will ignore them and default to the generic error page. First I tested with a custom error page less than 512 bytes and had the behaviour you described; then I tested with an custom error page of 3032 bytes and the custom error page is used as intended. Can you confirm if using a larger-sized custom error page works for you as well?
-garryn
splittingred created Redmine issue ID 2389
Manager Actions and System Events pages do not use 0.9.7 functionality and need revamping.
bobray created Redmine issue ID 2360
The right-click drop-down menu for elements should include an “edit” option like the menu for resources.
opengeek created Redmine issue ID 2372
The will allow named profiles to encapsulate default attributes for sending email, such as using sendmail vs. SMTP, providing SMTP details, default subject, default sender, etc.
sottwell created Redmine issue ID 2398
Please consider putting the logged-in user and the logout link back up on the main tool/menu bar. I miss it!
rethrash created Redmine issue ID 2376
Here’s an example email (password altered but otherwise a copy): Hello nnHere are your login details for My MODx Site Content Manager:nnUsername: nPassword: cRZZZxU3nnOnce you log into the Content Manager (/Library/WebServer/Documents/modx/manager/), you can change your password.nnRegards,nSite Administrator Looks like the username and the URL are not getting properly processed. I suggest altering the default message to: Hello [ufn]], Here are your login details for the [[sname]] Content Manager: Username: [uid]] Password: [[pwd]] Once you log into the Content Manager ([surl]]), you can change your password. Regards, [[sname]] Site Administrator -———————————————————-
In addition to the notification emails not working properly by default, the generated passwords also fail to log the users in. rthrash -————————————————————
I’ve fixed the password problem; it was saving it unencoded into the database. Will work on the default email text and replacement values next. -opengeek
splittingred created Redmine issue ID 2395
Refactor the way i18n is loaded into the manager interface, so that not all of the language strings have to be loaded at the same time. This will be done via “lexicon focus areas”. A model of the new lang dir: english/
english/context.inc.php
english/default.inc.php
english/chunk.inc.php
english/template.inc.php And so forth…
jrochman created Redmine issue ID 2370
Go to the elements tree. Create a category. Create another category. Drag the second category into the first. The other elements will not reflect the change. Visual representation. Templates
-Category
—Second Category
Template Variables
-Category
-Second Category
Chunks
-Category
-Second Category
Snippets
-Category
-Second Category
Plugins
-Category
-Second Category
bobray created Redmine issue ID 2342
At present, there’s no way to tell which file you’re editing in File Manager unless something in the file content tells you. In a directory with many similar files, it’s easy to forget which one you’re working on. One suggested solution to MODx-59 would take care of this at the same time.
bobray created Redmine issue ID 2361
When “add another” is checked for editing chunks, snippets, or resources, clicking on save does create a new screen for adding another item but “add another” is no longer checked (changes to “continue editing”).
splittingred created Redmine issue ID 2387
Backup page needs to be converted or refactored to use transport/097 functionality.
bobray created Redmine issue ID 2396
The Configuration tab should really have a different name, to prevent confusion with Tools | Configuration. I’d suggest “Status” or “Site Status” for the tab.
bs created Redmine issue ID 2345
Updating an element attached to an existing category throws an error: “An error occurred while trying to save the category” log: (ERROR @ /modx/connectors/element/snippet.php) Error 23000 executing statement:
INSERT INTO `modx_categories` (`category`) VALUES (:category)
Array
(
[0] => 23000
[1] => 1062
[2] => Duplicate entry ‘Jot’ for key 2
) Because i only have chunks and snippets i can only confirm that this happens for both these element. Reproduce: Create a category Create a chunk in this category Reopen the chunk you just created (have to be sure it’s reloaded) Click save without touching the existing category dropdown Cause: When loading an element the formfield value of the Existing category (id: category) is populated with the NAME of the category instead of the ID.
When saving, this results in an insert of the category which fails because of duplicatie keys. If you touch the dropdown and make a selection the formfield value is correctly populated with the category id of the selection which enables the update to perform correctly.
sottwell created Redmine issue ID 2392
When editing a policy with a long list of properties the scrollbar does not appear initially, one needs to close the list view then open it again.
rethrash created Redmine issue ID 2394
For the main document contenxt menu, the preview function is very nice. Essentially it launches that particular page in a new window (from 0961 or maybe 096 I believe). For the elements context menu (Templates, etc.) adding a direct way to access the editing functions and a way to duplicate would again be nice. When duplicating any element or resource, I future think it should go directly to editing mode, too.
bobray created Redmine issue ID 2353
Title says it all.
splittingred created Redmine issue ID 2380
Convert to 0.9.7. Talk with Jason about this possibly being a new Resource Type and how to handle it from there.
bobray created Redmine issue ID 2357
Work in the Manager would go significantly faster if the blue closed items bars (Elements and/or Files) appeared just below the open items rather than at the bottom of the screen. When going back and forth between Resources and Elements, it’s annoying to have to keep moving the mouse all the way to the bottom of the screen to switch.
bobray created Redmine issue ID 2362
Snippets and chunks that are locked for editing can’t be edited, even by the main admin, until locked status is changed in PhpMyAdmin. Also, the “item is locked” error message should probably be the same for all locked elements.
opengeek created Redmine issue ID 2383
Found several problems in user management: New in the toolbar when viewing the grid results, in message: “No action with ID 11 found.” Several required fields should automatically select default values (Editor to use and Language specifically) When saving a new user without selecting a gender, the grid of users will no longer load. Close and Continue Editing options both just continue editing; close should act like Cancel after a save. After creating a new user and selecting role of Administrator, logging in as that user results in no permission to do anything, including logout.
bobray created Redmine issue ID 2384
To reproduce: Rename MODx directory. Do Upgrade install. Old directory name still in config.core.php.
opengeek created Redmine issue ID 2373
Implementation of a native class to wrap external PHP mailer libraries like PHPMailer. This will allow MODx developers to call on mail services in a consistent way, yet allow various mailer engines to be utilized and easily interchanged.
bobray created Redmine issue ID 2347
Trac URL should be updated or deleted: Line 474 : _build\data\transport.core.menus.php
jrochman created Redmine issue ID 2371
Fresh install of Rev 3410. If I go to Reports→System Events I get the following error: “Fatal error: Class ‘ContextMenu’ not found in C:\Program Files\wamp\www\MODx3410\manager\controllers\system\event\index.php on line 25”
splittingred created Redmine issue ID 2382
Currently 0.9.7 only supports TinyMCE as another RTE. Figure out how to get others supported/installed/etc.
conseilsweb created Redmine issue ID 2378
Susan Sottwell found a problem after setting ‘Disable Global Cache Options’ to ‘yes’ in manager configuration. Manager became inaccessible with error : ‘(ERROR @ /manager/index.php) Could not load context: mgr’ Front-end was working with error showing on top: ‘(ERROR @ /index.php) Could not load context: web’ ‘(ERROR @ /index.php) Error caching resource 1’ I could not reproduce the problem.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.