modo-studio / unsplashkit Goto Github PK

Is this framework supported?

What

I want to add 10 random images to an array of UIImages

Context

My goal is to put the images into a table view

Proposal

Attach your own proposal (if you have it). We'll discuss in on the issue to find the best one that fits into the library.

In addition, when I print the array count after adding it, it prints out 0. Why so?

Thank you.

What

I get the following compile errors on file Source+Calls.swift
Cannot convert value of type '(Result<UnsplashImage, NSError>) -> Void' to expected argument type '(Result<(UnsplashImage, URLResponse), NSError>) -> ()'

Context

I create new project [(https://github.com/megimix/UnsplashWeatherApp)] and install your pod.

Our project only uses Swift Package Manager.
I think more developers will like it if we support Swift Package Manager.
Thank you.

What

The current project setup only supports CocoaPods. The purpose of this issue is supporting Swift Package Manager from the library.

Context

SPM is becoming popular and some projects are already using it. Giving support to it will make it easier for developers to integrate the library into their projects.

Proposal

• Prepare a Swift script that creates symbolic links in a Sources folder.
• Add the Package.swift.
• Validate the package build.

References

• RxSwift project has a script that creates the symbolic links. It could be a good reference.

This is more a question than an issue.

What

At random times, my query returns this placeholder image for no results, while no error is thrown.

Context

I use the UnsplashClient().randomPhoto(fromSearch: [searchTerm]) call with searchTerm being a name of a city entered by a user. The result of this call seems to always be .success.

What

Using cocoa pods, and adding UnsplashKit in my apps, when compiling the compiler is generating various build error.

Context

Simply create a new app using the current UnsplashKit from Cocoapod on Mac OS High Sierra... Try to build the app, and see compiler error.

See screenshot below for the issues reported

current docs say that you authenticate like:

var token = "xxxx"
var client = UnsplashClient { request -> [String: String] in
    return [ "Authorization": "Bearer \(token)"]
}

this should be

var token = "xxxx"
var client = UnsplashClient { request -> [String: String] in
    return [ "Authorization": "Client-ID \(token)"]
}

not sure when this changed, but the using the Bearer format fails auth

It complains about the typealias for NSImage and UIImage and some CGSize in watchOS.

cc @sergigracia

You can push directly to CocoaPods with

bundle exec fastlane push