mobsya / scratch-vm Goto Github PK

When pressing the stop buttons in Scratch it should also stops the motors.

also related to #44 different system to calculate time and speed for making angle. very special the non linear part for angle <90. Probably it works for a specific robot.

 turn (angle, callback) {
        angle = parseInt(angle, 10);
        let speed;
        let time;
        if (Math.abs(angle) > 90) {
            speed = 65 * 32 / 10;
            time = Math.abs(angle) * 1.3;
        } else {
            speed = 43 * 32 / 10;
            time = Math.abs(angle) * 2.0;
            time = angle * angle * 2.0 / ((Math.abs(angle) * 1.016) - 0.52); // nonlinear correction
        }

        const args = Array();
        args.push('Q_add_motion');
        args.push(time);
        args.push((angle > 0) ? speed : speed * -1);
        args.push((angle > 0) ? speed * -1 : speed);

       // Send request
       this.requestSendQmotion(args, 2, callback);
    }

  turnWithSpeed (angle, speed, callback) {
       angle = parseInt(angle, 10) * 0.78;
       speed = parseInt(Math.abs(speed), 10);
       speed = parseInt(clamp(speed, Thymio.VMIN * 10 / 32, Thymio.VMAX * 10 / 32), 10);

       if (angle === 0) { 
           const args = [speed * 32 / 10,-speed * 32 / 10]; // speed=10mm/s
           this.sendAction('M_motors', args,callback);
       } else {
           const time = Math.abs(angle) * 100 / speed; // time measured in 100 Hz ticks
           speed = speed * 32 / 10;

           const args = Array();
           args.push('Q_add_motion');
           args.push(time);

           if (angle > 0) {
               args.push(speed);
               args.push(speed * -1);
           } else {
               args.push(speed * -1);
               args.push(speed);
           }

           // Send request
           this.requestSendQmotion(args, 2, callback);
       }
   }
  

Some block like the set led proximity send command that inactivate the default behaviour of showing the intensity of proximity sensor. That can be problematic if you make a program using it and then pass to a program that do not use it (file new or loading), the default behavior will not be there.

The actual work around is to kit scratch or to shutdown the robot (wait until scratch see that the robot disappear) ,

Another solution is to make a "reset" block that will put the robot in a known state, letting users choose when to reactivate the behavior, is that needed?

I tried the Odometer block which has three parameters Direction, X and Y.

The Direction is odd. If you use the Set odometer block and put a value as init, the value of the odometer Angle block will be 1 or 2 below the init value and then, as soon as you rotate with the motors, the value jumps. I tried the following:

Set value: 0 => read value 176
Set value: 50 => read value 126
Set value 100 => read value 76
Set value 200 => read value -24

Then, it seems that the 0 value of the direction makes the robot face the minus Y axis. In my opinion, it would be more intuitive to have the robot face the + X values.

The value of the Direction is defined on a range of -90 to 280 which I also find strange. If you just rotate and look at the values you get, it's like that. I would suggest either to have a 0 to 360 or -180 to 180.

Finally on the X and Y axes, the units are strange. On the general other blocks like "move ()" or the speed, we use mm or mm/s. Here is just a coupe of measures I did:

10 units of odometer => ~5.5 cm
20 units of odometer => ~11cm

Should we use the same ~mm units we use for the rest, especially for the "move ()"? Otherwise, it will be very hard to use this odometer block.

Operating System and Browser

Windows 8.1, Version Thymio Suite Beta 2 online on thymio.org (2.0.0-350ce8fc BETA)

infinite repeate are making to much http request
it is working with putting a wait 0 sec

if we can improve that with actual web bridge would be great, otherwise we have to wait TDM

it only send 0 to the motors and if you have a ongoing mouvement it can continue

sound only 0 to 3 to be checked

the function is working but then it is overwrited by the motion control step

actually it is a variable

connect to the correct Thymio given in the the link provide by the Launcher

upstream uses transifex to translates scratch

I suggest we do the same

Rough idea:

• 1 In the code, use https://www.npmjs.com/package/format-message (as the rest of scratch) to format translatable text
• Modify package.json to extract thymio-specific in a separate files
• Create an account transifex or similar service
• Push the generated file on said service
• translate...
• sync trads

garder la façon calculée

it take account of the angle but the radius has no effect

I stumbled upon the following error which makes scratch unusable for me

Uncaught TypeError: this.cachedValues.get(...).slice is not a function
    at Thymio.touchVal (lib.min.js:303246)
    at Thymio.notouching (lib.min.js:303278)
    at Scratch3ThymioBlocks.notouching (lib.min.js:304755)
    at execute (lib.min.js:289860)
    at Sequencer.stepThread (lib.min.js:293454)
    at Sequencer.stepThreads (lib.min.js:293356)
    at Runtime._step (lib.min.js:292110)
    at lib.min.js:292759

it seems we loose in stability:
see Mobsya/aseba#503
probably reducing sending events should help

selon discussion sur https://3.basecamp.com/3669958/buckets/9095317/messages/1531479185

rapprocher les blocs de la terminaison scratch mais sans mettre d'unité

Expected Behavior

I was programming something, displaying some variable on the Sprite screen (where there is the cat) and suddenly the screen blue-screened as below

Actual Behavior

I tried to go full screen to press the refresh button but it did not work. Loading a new program, a blank one or changing the language didn't fix the problem. Reloading Scratch completely fixed the issue.

Steps to Reproduce

Apparently these specific things don't work:

These work fine:

It's really when you press the refresh button that the sprite zone go blue-screen:

Operating System and Browser

Windows 8.1, Version Thymio Suite Beta 2 online on thymio.org (2.0.0-350ce8fc BETA)

I tested a few things on a Windows 8.1 machine, Chrome, Wireless Thymio and classic Thymio:

1. When connecting to the Thymio extension, the forward or left arrow LED is always lit on. It does that on Wireless and classic Thymio. Sometimes it's the forward, sometimes the left. It's really when the scratch extension connects to Thymio not the web bridge or anything else. Some LEDs blink (like the circle ones) and then, one of the button LED lights on and stays like that.
   I found a funny thing with that. If you just use this block:
   
   and click on it, the button LED that is next to the one always lit light up a bit (like half of power) and when the motors are stopping the LED that was lit turns off and the one that was half lit lights up completely. It does some sort of a circle, one LED after the other.
   You can also do that with this block:
   

2. Leds clear => doesn't clear the horizontal sensors LEDs

3. leds buttons => just blink and does not stay as you ask. Doesn't fix the constant lit on LED either

4. Should we add a "is pressed" at the end of the button event?
   

5. While using a Wireless Thymio, some commands are sent but are not executed by the robot. Doesn't happen with classic Thymio. I did this simple program:
   
   and saw a ~10% time failure on one of the two motors. Also happens if you just command one motor, sometimes it doesn't stop or doesn't turn on.
   it's problematic on some occasion such as this one:
   
   The robot just stops after X movements and doesn't go back in the loop. I tried with all the three channels and the problem occurs in each three of them. Sometimes it's after 5 loops, sometimes, you can do 20, but in the end, it always stops.

6. With the "turn X° in Y sec", you can put negative time and it seems to do the same thing as positive time:
   

Couldn't we block some values? Like only positive? Just do some sort of absolute value?
Same thing with smaller than 0 values. For example, I program my robot to turn 90° in 3 seconds:

It works nicely. Then I decide to go much faster and put 0.5 seconds instead:

And it does the 3 seconds one. Even if I change the value of the angle, the robot does the same thing all over again. It's only when I put back a bigger than 1 value that it does what I want. But I get no warning or anything.

One good point is that the connection is much more stable than before and the delay between orders and execution is much smaller (I had around 10-15ms max)

should we handshake every thing?

ne peut pas faire de rayon plus petit que la distance entre les roues (~10cm) car si on met un petit rayon, on arrête une roue et fait avancer l'autre.
Est-ce qu'on peut modifier le code généré par le bloc pour faire des plus petits rayons ? (typiquement une roue en marche avant, une en marche arrière) C'est notamment intéressant si on veut faire des dessins genre spirographes.

strange behavior

Expected Behavior

When multiple blocks are on the work area I select them and I can move them together. When I press the right button on the mouse a pop-up window menu opens and I select to delete all the blocks selected. I expect the blocks to be deleted.

Actual Behavior

The blocks are not deleted

Steps to Reproduce

put any block into the work area. Select 2 or more blocks. Right clic on the mouse. Press delete N blocks (where N is the number of blocks you selected) and you see that nothing is done.

Operating System and Browser

Mac OSX High Sierra 10.13.6 - Firefox Quantum 66.0.3

one of the useless information that Thymio can provide is its internal temperature, should we make a block for it?

latest commit that improve the stop button introduce a bug when you make sequence of mouvement like a square

Expected Behavior

When I have created a program in Scratch 3 I want to start a new program and delete all the blocks on the work area I press File -> New and I expect to see a new blank work area

Actual Behavior

No action. Nothing happens.

Steps to Reproduce

Put any block on the work area. Then press the menu FILE and then New and nothing happens.

Operating System and Browser

Mac OS High Sierra Version 10.13.6 - Firefox Quantum 66.0.3 64 bit

we can discuss it because i would expect that it does is but it is not done to keep the normal behavior of pulsing with the sensor when user do nothing with them

actual bloc only start sound recording with a number as parameter (should be positive)
add a stop recording bloc (send -1 as value)

if a negative angle is there the moteur go all with speed do not work, all other are fine

a connexion status should show if robot is still connected, it should show the friendly name somwhere

Expected Behavior

when the option all is selected all led should be the same, it is not the case

Actual Behavior

bottom color are false

but if you use the other option [top, bottom, bottom left, bottm right) the block is working

Capteurs horizontal:
Gauche
Centre - gauche
Centre
Centre - droite
Droite
Arrière gauche
Arrière droite
Capteur dessous:
Gauche
Droite

I had a phone call with a Scratch beta user and he told me that on Mac OS, the save and open file features are not working. As I don't have a Mac, difficult to check. Is it already known?

Expected Behavior

Please describe what should happen

Actual Behavior

Describe what actually happens

Operating System and Browser

_e.g. Win 10 Chhrome 69.0.3497.92 (Build officiel)

if you give number that are not a multiple of 10 the ouput number is not an integer and command is not correct.

it is not sure that it is handle corretly in the aesl inside the robot

it is the default scratch Bluetooth windows, could be more adapted to our case

only value 0 or 500

this code is quickly stop because Q-motion only relays on user messages, it should also take account status to handshake commands

related to issue #49 reloading an program should reset the robot so that basic behavior (like proximity led showing prox intensity) are activated

the blocks of several variable like proximity h, proximity ground add a check box on scratch X, it should be there otherwise there are not usefull