mneri / offer-service Goto Github PK

Split the OfferRequestDto into two different objects: OfferCreateDto and OfferUpdateDto.

Most CRUD operation inside the controllers are not transactional. Move the business logic from the presentation layer to the service layer and make sure everything is executed inside a transaction.

The service layer is depending on OfferCreateDto and OfferUpdateDto. The dependency should be removed.

Configuration classes are located in different packages. Create a configuration package and move them inside.

Rename DefaultOfferService into OfferServiceImpl and DefaultUserService into UserServiceImpl.

The root package (me.mneri.offer) should only contain the following packages:

1. presentation for the presentation logic;
2. business for the business logic;
3. data for the data access logic;
4. share for the shared interfaces between the layers;
5. configuration for Spring configuration files.

As in the title.

The UserSpecification and OfferSpecification classes are part of the data layer of the application. These classes are directly imported by the service layer classes violating the dependency inversion principle of SOLID.

Right now there are two mappers:

• OfferMapper which maps all the offer related classes;
• UserMapper which maps all the user related classes;

There should exist one mapper per application layer: data, service and presentation. This will provide a much more solid isolation between layers.

There exist only 3 different types of exception:

1. UserIdNotFoundException
2. UserNotAuthorizedException
3. OfferIdNotFoundException

These exceptions are often used in the wrong context. For example, UserIdNotFound is both used when the user is not found or a user exists but is not enabled.

Create more specific types of exceptions.

The API returns the complete list of results (users or offers). The result should be paged.

It just does not make sense.

Entities are part of the data layer and should be isolated. Create an interface for each entity so to hide the implementation from the rest of the application.