mmsdc / qanda Goto Github PK

Congratulations on completing SDC!!

[This is a review for the entire group]

After going through the code base there were a few areas of growth that, if developed, would lead to better performance, security, and readability.

Taking consideration of these comments and making a cognitive effort to avoid similar habits in the future will make meaningful improvements to your skillset.

Things to keep in mind:

• Ensure files are kept in directories for organization purposes. As a project scales, so does the need for well organized file hierarchy.
• leftover comments (on final commits, remove any unused code or unnecessary comments)
• using JS iterator function in DB query [can cause a DB traffic jam, causing through put to prematurely saturate]
• JS looping in a DB query (DBs are designed for this, so find a way for the DB to handle this)
• always ignore *.env or connection config files
• ensure consistency with promises or callbacks (choose one or the other)

Overall the project looks good, feel proud of your accomplishments!