Description

I have been testing your branch feature/SecurityPolicy#Basic128Rsa15 and have found a few minor
issues that I thought I should share with you.

In file plugins/ua_securitypolicy_basic128rsa15.c

• All mbedtls #includes use backslash instead of frontslash which fails compiling in linux.
• In function policyContext_setCertificateTrustList_sp_basic128rsa15(), certificate trust list is parsed using mbedtls_x509_crt_parse_der() (row 94). Is there a reason to require DER format, or could the function mbedtls_x509_crt_parse() be used instead?

In file plugins/ua_config_standard.c

In function UA_ServerConfig_standard_basic128rsa15_new(), the port is hardcoded to 16664 (row 333), but is available as an input parameter to the function, portNumber.

Application and product URI

I also have another issue that might require a slight rewrite. When using UA_ServerConfig_standard_basic128rsa15_new(), the applicationURI and productURI are not set on the created endpoints. If I recall correctly, the UaExpert client requires that the URI in the application certificate matches that of the endpoint used. My workaround is currently as follows:

UA_ServerConfig *config = UA_ServerConfig_standard_basic128rsa15_new(
    port,
    &cert,
    &privateKey,
    &trustList,
    NULL); // revocationList

config->applicationDescription.applicationUri = UA_STRING((char*)"<something that matches certificate URI>");
config->applicationDescription.productUri = UA_STRING((char*)"<something else>");

// Workaround
// Make sure that all endpoints also have the same applicationUri
for (unsigned int i = 0; i < config->endpoints.count; i++) {
    config->endpoints.endpoints[i].endpointDescription.server.applicationUri =
        config->applicationDescription.applicationUri;

    config->endpoints.endpoints[i].endpointDescription.server.productUri =
        config->applicationDescription.productUri;
}

Thank you for your effort! I am following your progress with great interest :)

Description

I have been testing your branch feature/SecurityPolicy#Basic128Rsa15_new under the CTT test suite Monitored Item Services/Monitor Items 5000 while using Basic128Rsa15 security policy and SignAndEncrypt security mode and have gotten the following error:

CreateMonitoredItems.Response.ResponseHeader.ServiceResult is Bad: BadDecodingError (0x80070000)

However, all tests pass when using None security policy and None security mode.