dass-wills's People
dass-wills's Issues
Create unit tests for distribution scenarios
Using the distribution chart created by Salena and Derek, create unit tests that model the scenarios and their respective distributions. I will push a pdf of this chart onto this branch, with a readme.md, for convenience.
file name for output pickle file
@pawnsac Thanks for the code. I have a couple of minor tweaks I'd like to request:
- Right now the name of the output pickle file is derived from that of the input JSON file. This potentially has the disadvantage that for an input JSON file
will01.json
the piclke file is namedwill01.json.pickle
, which can be confusing by making it seem as though it's the JSON file that's being pickled. Would it be possible to name the output pickle file by removing the.json
suffix from the input JSON file, i.e., if the JSON file iswill01.json
then the output pickle file iswill01.pickle
. - In the output line printed by the program,
exporting the will object...
can you just add the name of the file being exported to?
devolve_will.py
@pawnsac The file devolve_will.py
has a few style issues that should be fixed. Where possible let's try to be consistent with PEP-8 (https://peps.python.org/pep-0008/).
- Maximum line length = 79 (https://peps.python.org/pep-0008/#maximum-line-length)
- Adjacent function definitions should be separated by two blank lines (https://peps.python.org/pep-0008/#blank-lines)
- The file has a banner "UTILITIES" near the top but no other banners, suggesting that the file consists entirely of utilities and nothing else.
- Please check the
import
statements at the top to make sure they make sense. For example,Person
is imported but it's not used in the code.
Code update for revised JSON
Fix Python code for executing+devolving wills to work with the revised JSON format.
Python issues in extractions.py
The are a couple of minor Python issues in file extractions.py
in the branch design-attempt-01
that should be fixed before we merge everything into main
:
- I'd like to try and stay with the style guidelines in PEP-8 (https://peps.python.org/pep-0008/). One of the guidelines is that lines of code are at most 79 characters long. This file has a few lines longer than that, these need to be fixed. This tool may be helpful for this: https://github.com/astral-sh/ruff
- It would be helpful to have some documentation at the top indicating the purpose of this code and also how it should be invoked.
- For each of the classes defined in this file, some documentation indicating what it's for and where+how it will be used.
Thanks!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.