mkoopajr / hapi-session-mongo Goto Github PK

cant install this module, instead i use https://www.npmjs.com/package/bcrypt-node

This code could be written simpler

module.exports = function(options) {
    options = options || {}; // ensures that options is not undefined
    var ip = options.ip || '127.0.0.1', // very simple || works here
        port = options.port || 27017,
        dbName = options.db || 'test',
        dbUser = options.name, // no need for undefined, it's undefined if it's undefined :)
        dbPwd = options.pwd
        ssl = options.ssl, // false not required here, undefined is falsey and should work
        ttl = options.ttl || 0;

This is errback style

foo(function(err, data) {
    if (err) {
         return callback(err);
    }
   //Proceed with happy path logic
});

Instead of callback(false) use callback(null). null means it's ok
Instead of callback(true) use callback(err). err allows the user to respond to the actual error

If you are generating an error, as in invalid config or something use:
callback(new Error('you did something wrong'))

Code:

• https://github.com/Mkoopajr/hapi-session-mongo/blob/master/lib/users.js#L29-L30
• https://github.com/Mkoopajr/hapi-session-mongo/blob/master/lib/users.js#L69
• https://github.com/Mkoopajr/hapi-session-mongo/blob/master/lib/users.js#L72
• https://github.com/Mkoopajr/hapi-session-mongo/blob/master/lib/users.js#L75

When you are testing you will want to set this up on TravisCI.

You will need to create a shell script that will install MongoDB and prep it with dummy users. The setup the ENV variables and start the tests.

Bunch of docs here: http://docs.travis-ci.com/user/languages/javascript-with-nodejs/

Once that's hooked up (you have to make this repo public before that) you need to also add a section to the readme about testing, etc..