mkirchner / hamt Goto Github PK

It's really just a bad habit.

The naming of the foundational structs is confusing and does not align well with the explanations in the docs

struct kv -> struct leaf
struct table -> struct node (or internal or leave as table?)

I've been studying HAMT recently, and there's very limited public information available. I consider myself fortunate to have come across this repository, and the material you've provided has been of great help to me. Additionally, I wanted to ask if you've considered adding concurrency support. I understand that implementing concurrency for persistent data structures might not be overly complex, and hazard pointers could potentially be used. Do you have any thoughts on this? :)

hi, could you please teach me which the tool you used to draw the nice graphs in readme

"Because it's a tree, operations like union and difference of two instances can be sublinear in the size of the instances. E.g. union can copy subtrees when the other instance has empty at the corresponding position."

There are a few macros that should be renamed to allow for clearer presentation:

tagged -> tag
untagged -> untag
is_value -> is_leaf // ?

"You're also missing a batch construction call, create a new tree out of N key/value pairs. That's much faster than inserting one at a time because you can sort the array up front and then create the tree without any temporary nodes."

Not sure if this is feasible since the sorting is defined by the hash function...