mkhytarmkhoian / conductor-dialog Goto Github PK

Hey,

Are there any plans of adding a readme for this?

I am surprised no one needed bottomsheet in conductor apps. Do you have any plans implementing it?

Hi, using dialpg controller via router.pushController, opens up screen woth dialog but removes the view underneath.

Is this as indended? If so, kind of beats the purpose of dialogs

Also

Since is a whole new controller, how can I pass a listener to the caller controller?

thamks

Hi, a really nice piece of code. I'd like to know how can I create a custom Dialog. I was looking for the demo and I saw just a classic alert. So, is it possible to use that?

Hi,
restoring state of controller works (i.e. after rotation dialog stays (comes up again) shown)

However if I put a view inside my alert dialog (usecase: title, edittest, cancel button, ok button)
then the text inside edittext is not restored after config change. DialogFragment does this, so I presume this is a bug

I looked around the source and the problem seems to be that you do save the dialog instance state at line 237. However you never restore it. Looking at the DialogFragment is should be after the

dialog.setOwnerActivity(getActivity()); dialog.setCancelable(cancelable); dialog.setOnShowListener(this); dialog.setOnCancelListener(this); dialog.setOnDismissListener(this);

combo of setters.

I would restore it myself, but you made onBindView private and onCreateView final

(Btw looking around with debugger, onRestoreInstance state was never called for me after rotations, is this also as designed?)

Workaround for now is to manually do it via

override fun onRestoreViewState(view: View, savedViewState: Bundle) {
       super.onRestoreViewState(view, savedViewState)
       editText?.onRestoreInstanceState(savedViewState.getParcelable("foo"))
   }

   override fun onSaveViewState(view: View, outState: Bundle) {
       super.onSaveViewState(view, outState)
       val foo = editText?.onSaveInstanceState()
       if (foo != null) {
           outState.putParcelable("foo", foo)
       }
   }