class attribute has label 'instance-attribute' about griffe

[ixje]

I agree with your analysis. Most important for me was realizing that a value must be assigned before __init__ for it to be labelled as class-attribute

[pawamoy]

From a user point of view, myclass_attribute is accessible both from the class (MyClass.myclass_attribute) and the instances (myclass.myclass_attribute), so it should have both class and instance labels (not sure why it does not get the class one, I'll check). If you want the attribute to only have the class label, you can use typing.ClassVar:

from typing import ClassVar

class MyClass:
    myclass_attribute: ClassVar[float]

[pawamoy]

OK, so IMO it makes sense:

• if your class attribute does not have a value (only an annotation), users cannot access it at runtime on the class, so no class-attribute label
• however, Griffe expects that its value will be set in the __init__ method (either explicitly or thanks to dataclasses for example), therefore it sets the instance-attribute label.
• finally, a class attribute with a value will also always be accessible on instances, so class attributes with values always get an instance-attribute label

Let me know what you think. In the meantime I'll close this issue as I think the behavior is correct as it is.