Comments (3)
Hey again @the-13th-letter, thanks for the great report. I agree with the suggestion to make yields
and returns
consistent. Maybe also receives
?
from griffe.
Hey again @the-13th-letter, thanks for the great report. I agree with the suggestion to make
yields
andreturns
consistent.
:)
Maybe also
receives
?
I thought about that as well, but I don't have a good case for this. Just a couple of disjointed random thoughts.
-
Google's style guide doesn't talk about generator input via
generator.send(...)
at all. So it's anyone's guess how to properly format this or even talk about this in a valid Google-style Python program. -
The Receives block comes from
numpydoc
. So it's much more important that it is compatible with NumPy's style than with Google's style.numpydoc
currently (v1.8.0rc0) says: “Since, like for Yields and Returns, a single object is always passed to the method, this may describe either the single parameter, or positional arguments passed as a tuple.” So there may be some desire forreceives_multiple_items = False
.- The function analog to Receives is (positional-only) Args/Parameters. I cannot really imagine anyone seriously suggesting that the Args/Parameters block should support not accepting multiple parameters. Why would Receives be any different? So maybe there's no desire
receives_multiple_items = False
.
- The function analog to Receives is (positional-only) Args/Parameters. I cannot really imagine anyone seriously suggesting that the Args/Parameters block should support not accepting multiple parameters. Why would Receives be any different? So maybe there's no desire
-
I find the need for
receives_named_value = False
somewhat unlikely: you generally dospam, eggs, *parrots = yield ...
inside the generator, so you already have “parameter names” (spam
,eggs
,*parrots
) that you probably want to use in the Receives block.- But then, perhaps it's a
spam = yield ...
case wherespam
is an internal name that you don't want to expose, and now the docs are forcing you to name things anyway...
- But then, perhaps it's a
So yeah, I don't really know what to do with Receives. And I don't think I'm the right person to ask about that either, because I use neither Receives nor the NumPy docstring format in general.
from griffe.
Thanks for your thoughts.
So yeah, I don't really know what to do with Receives. And I don't think I'm the right person to ask about that either, because I use neither Receives nor the NumPy docstring format in general.
Then I'd vote we make "Receives" consistent with the rest, for the sake of consistency. Both Google-style and Numpydoc-style are underspecified, so I always allowed myself some wiggle-room with the goal of making both styles more similar, structurally speaking.
from griffe.
Related Issues (20)
- bug: Regular classes that inherit dataclass do not get dataclass parameters HOT 1
- bug: A class that derives from a dataclass should be labelled a dataclass HOT 2
- feature: Merge value when attribute is first annotated then assigned
- docs: bad link HOT 2
- feature: Future backward-compatibility warnings
- feature: API checks: diff each sequence/mapping value instead of the whole
- bug: Error reading page: tuple index out of range HOT 3
- feature: API checks: Report new positional-or-keyword parameters inserted before other positional-or-keyword parameters
- feature: Warning/hint for objects coming from siblings/parents/external exposed in __all__
- feature: Format/highlight expressions?
- feature: link to re-export instead of inserting full documentation HOT 4
- bug: when using `import x.y.z as a`, Griffe thinks `a` is an alias for `x`, not `x.y.z` HOT 4
- bug: parsing of annotations placed after parameters section fails HOT 1
- docs: Add an example CI setup HOT 1
- bug: Custom implementation of cached_property results in property being categorized as a "method" instead of a cached property HOT 7
- feature: extension(?): relative cross-references in docstrings, but resolved by the handler/extractor HOT 6
- feature: Pre-commit integration HOT 4
- feature: Allow passing multiple args to `Object.has_labels` instead of a set
- feature: Allow passing multiple args to `load_extensions` instead of a list
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from griffe.