Comments (4)
Hi @mitsuhiko . Thanks for taking interest in my request. Any news on this feature ?
from minijinja.
@NikolaLohinski i looked into it recently again and it's quite a pain to implement and I wasn't sure if this feature is really that useful since editors also won't be able to handle custom Jinja delimiters. I just added raw tags, could they be helpful instead? (#69).
from minijinja.
Hi @mitsuhiko thanks for answering.
Regarding the raw tag : it would not help me because it would require me to escape every piece of conflicting delimiter every time I encounter them and there is lot.
Regarding editors : I don't understand how this is relevant to the feature itself. For sure most editors won't be able to parse jinja files with other delimiters but usually (at least for me), you want the file to be highlighted with the editor config for the underlying language, not for jinja itself. Should you have to template Python files (for whatever weird reason), you'd want the editor to show Python, not plain text with Jinja. My personal use case is to template HCL files.
Finally, if you consider it hurtful to implement, I can definitely look into it and take a shot at it if you would be so kind to accept a PR, and ideally give some thoughts on how you'd envision it.
from minijinja.
I would be open to a PR if it does not pull in a new dependency. There are however definitely some API limitations right now that would have to be worked with. For one a new Settings
object or similar could be added that's passed between the environment, template and the meta
API and the lexer and other internals.
The tricky bit will be that using memstr
internally will no longer work. For efficiently parsing arbitrary delimiters one would probably want to use something like aho-corasick except i don't want to add a dependency. If aho-corasick turns out useful, it could be added as an optional feature with the extra dependency.
from minijinja.
Related Issues (20)
- 2.0: EnumerationIter cannot be DoubleEndedIterator HOT 1
- 2.0: Align iteration protocol with MiniJinja 1 HOT 14
- 2.0: Reintroduce Value::from_iterator HOT 5
- 2.0: Non Object Objects
- 2.0: DynObject is not an Object HOT 1
- Don't allocate to `reverse` HOT 1
- 2.0: One-Shot vs Repeatable Iteration
- 2.0: Rename Value::from_serializable HOT 1
- 2.0: Make Syntax extensible and move whitespace control into it
- `Object::len()` and `Object::is_empty()` conflict with inherent `len()`, `is_empty()` HOT 1
- 2.0: Investigate Performance Regressions HOT 2
- Add Protection Against Buffering
- `undeclared_variables()` stuck with `for loop` ({% for ... in ... %})
- String concatenation without "+" operator HOT 1
- Fallible Iteration
- set_lstrip_blocks should not apply to expressions, only to blocks.
- Custom time format strings HOT 5
- UndefinedBehavior::Strict and undefined key in mapping HOT 4
- Option to always chomp whitespace HOT 3
- async support for Object trait HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minijinja.