Coder Social home page Coder Social logo

Comments (2)

mitsuhiko avatar mitsuhiko commented on June 3, 2024

Quick investigation shows that Value::from for the &str in get_attr_fast is a pretty significant source of performance degradation.

from minijinja.

mitsuhiko avatar mitsuhiko commented on June 3, 2024

Note for later: I was pondering about this on the weekend and I think given how entrenched Value is now in object interfaces the correct course of action would be to leverage the fact that those objects are really large. They are basically 24 bytes in size, which would allow this thing to store up to 22 bytes without any complicated shenanigans inline. We use one byte on the ValueRepr itself for the variant, one byte we could reserve for the length and then the other 22 are the payload. While in the past it has been shown that Cow really harms the string performance, I think now that we pay such a high price elsewhere having another variant might not be so bad.

from minijinja.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.