Comments (2)
Quick investigation shows that Value::from
for the &str
in get_attr_fast
is a pretty significant source of performance degradation.
from minijinja.
Note for later: I was pondering about this on the weekend and I think given how entrenched Value
is now in object interfaces the correct course of action would be to leverage the fact that those objects are really large. They are basically 24 bytes in size, which would allow this thing to store up to 22 bytes without any complicated shenanigans inline. We use one byte on the ValueRepr
itself for the variant, one byte we could reserve for the length and then the other 22 are the payload. While in the past it has been shown that Cow
really harms the string performance, I think now that we pay such a high price elsewhere having another variant might not be so bad.
from minijinja.
Related Issues (20)
- 2.0: EnumerationIter cannot be DoubleEndedIterator HOT 1
- 2.0: Align iteration protocol with MiniJinja 1 HOT 14
- 2.0: Reintroduce Value::from_iterator HOT 5
- 2.0: Non Object Objects
- 2.0: DynObject is not an Object HOT 1
- Don't allocate to `reverse` HOT 1
- 2.0: One-Shot vs Repeatable Iteration
- 2.0: Rename Value::from_serializable HOT 1
- 2.0: Make Syntax extensible and move whitespace control into it
- `Object::len()` and `Object::is_empty()` conflict with inherent `len()`, `is_empty()` HOT 1
- Add Protection Against Buffering
- `undeclared_variables()` stuck with `for loop` ({% for ... in ... %})
- String concatenation without "+" operator HOT 1
- Fallible Iteration
- set_lstrip_blocks should not apply to expressions, only to blocks.
- Custom time format strings HOT 5
- UndefinedBehavior::Strict and undefined key in mapping HOT 4
- Option to always chomp whitespace HOT 3
- async support for Object trait HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minijinja.